Change minimum supported Laravel version to 5.6

[arkaitzgarro]

Change minimum supported Laravel version to 5.6

[arkaitzgarro]

If we are dropping support for 5.5, I would prefer to jump directly into 6. As you mentioned, none of the 5.x versions are supported anymore, I think it makes sense to have the 1.x version of this package compatible with Laravel >=5.5, and the next 2.x version compatible with Laravel >=6.X versions.

[dstepe]

After some more digging, I believe this change occurred in the 5.6 release (I forgot that Laravel did not start using semantic versioning until 6.x, so the 5.5 to 5.6 is a "major" release). The 5.6 release included a major change to the Monolog implementation.

Given that no versions of 5.x are supported for security releases any longer, I am willing to reconsider the minimum supported version for this package. The previous potential breaking change was easy to avoid. This one is not. I suggest that the minimum Laravel version for this package be bumped to 5.6.

[dstepe]

I agree. I noticed that the ScheduledTask events will required 6.x as well.

Will you create a release of the 1.x version that will include the new features that are compatible, but limited to Laravel >=5.5 <6.0? I'm going to push to get APM into our apps faster than my dev teams will be able to update (though I'm about to have the conversation regarding just how bad a support situation we are in). I'll need to maintain a compatible fork if there isn't an official release.

[arkaitzgarro]

@dstepe your idea will be to support Laravel >=5.5 but using the previous APM agent from philkra right? If that's the case, I can create a branch from the latest 1.X tag, an we can start migrating functionality. I'm afraid it will be an intense manual labour job, non of the latest changes is compatible with the previous version of the agent.

[dstepe]

I was actually thinking of branching what we have now, before merging in the change to bump to Laravel 6 minimum. The master branch is working well for me in 5.5+ Laravel apps. I'm not at HEAD with the latest changes, but I think we can get to a working release without too much effort. And leaving that on a branch will allow continued minor releases on the 1.x line. I don't mind putting in the work for that. I'm in a situation in which I want APM for a number of apps sooner than I expect them to be updated to Laravel 6+.

[arkaitzgarro]

I created a 2.x branch from latest changes, and restored the compatibility with Laravel 5.5. I also removed the incompatible collector. Unit tests are passing, the only missing update will be the getLogger/getMonolog breaking change in the Service Provider.

• Branch: https://github.com/arkaitzgarro/elastic-apm-laravel/compare/2.x

Unfortunately, GH actions declines to work when add Laravel 5.5 to the matrix, it does not install the dependencies...

[countless-integers]

Just mind that scheduled task collector is only included if one of the event class it uses is present and as such should not break for 5.5 users (haven't exactly tested that, but that's what I expect). So for 5.5 users this feature will not work, but also shouldn't break.

[arkaitzgarro]

Just mind that scheduled task collector is only included if one of the event class it uses is present and as such should not break for 5.5 users (haven't exactly tested that, but that's what I expect). So for 5.5 users this feature will not work, but also shouldn't break.

I had to remove it because L5.5 test were failing. We were importing the class, but since it didn't exist, PHP throws an error. I guess the proper solution is not import the class and use the fully qualified name if the class exists.

if (class_exists('Illuminate\Console\Events\ScheduledTaskStarting')) {
  $this->app->tag(\Illuminate\Console\Events\ScheduledTaskCollector::class, self::COLLECTOR_TAG);
}

[countless-integers]

🤦 yep, strong habit.

[dstepe]

I removed the Collectors which I understood to not be supported prior to Laravel 6. Added a version check to get the Monolog instances with the appropriate method for 5.5 and 5.6+, so the 2.x branch should support 5.5 - 5.8.PR #112 should be ready for review.

[arkaitzgarro]

Closed via #112