Giter Site home page Giter Site logo

Comments (5)

alexbarnsley avatar alexbarnsley commented on August 23, 2024 1

thanks πŸ‘Œ

from ledger-transport.

alexbarnsley avatar alexbarnsley commented on August 23, 2024

I think this issue is better off in the ledger repo. The bulk of the changes will be required there as per your statement This Ledger-Transport scheme is also used Ledger-side at Tx deserialization.

IMO this issue is overly complicated/wordy, especially when C is included.

from ledger-transport.

sleepdefic1t avatar sleepdefic1t commented on August 23, 2024

I disagree.

The HW side changes are almost complete.

All we need is for this JS package to send payloads using the official scheme at a minimum.

The big scary β€œC” examples were only to illustrate that the payload is incorrectly encoded.

I can edit this issue or make another issue that’s easier to understand and doesn’t use C as an example, but I’d still say a request for changes in the Transport package should be in the Transport repo.

from ledger-transport.

alexbarnsley avatar alexbarnsley commented on August 23, 2024

I'm happy for it to remain open (hence why I didn't close it). It needs editing to remove the "big scary C", because this is a JS repo - either use JS, pseudo-code or English. Also, terminology such as "serde" doesn't make sense to those who don't know them, so you should avoid using short-hand phrases in this sort of environment.

from ledger-transport.

sleepdefic1t avatar sleepdefic1t commented on August 23, 2024

updated πŸ‘

from ledger-transport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.