Comments (5)
thanks π
from ledger-transport.
I think this issue is better off in the ledger repo. The bulk of the changes will be required there as per your statement This Ledger-Transport scheme is also used Ledger-side at Tx deserialization
.
IMO this issue is overly complicated/wordy, especially when C is included.
from ledger-transport.
I disagree.
The HW side changes are almost complete.
All we need is for this JS package to send payloads using the official scheme at a minimum.
The big scary βCβ examples were only to illustrate that the payload is incorrectly encoded.
I can edit this issue or make another issue thatβs easier to understand and doesnβt use C as an example, but Iβd still say a request for changes in the Transport package should be in the Transport repo.
from ledger-transport.
I'm happy for it to remain open (hence why I didn't close it). It needs editing to remove the "big scary C", because this is a JS repo - either use JS, pseudo-code or English. Also, terminology such as "serde" doesn't make sense to those who don't know them, so you should avoid using short-hand phrases in this sort of environment.
from ledger-transport.
updated π
from ledger-transport.
Related Issues (20)
- [Weekly Digest] Jul 22, 2019 - Jul 28, 2019
- [Weekly Digest] Jul 29, 2019 - Aug 4, 2019
- [Weekly Digest] Aug 12, 2019 - Aug 18, 2019
- [Weekly Digest] Aug 26, 2019 - Sep 1, 2019
- [Weekly Digest] Oct 7, 2019 - Oct 13, 2019
- [Weekly Digest] Jan 20, 2020 - Jan 26, 2020
- [Weekly Digest] Feb 10, 2020 - Feb 16, 2020
- [Weekly Digest] Feb 24, 2020 - Mar 1, 2020
- [Weekly Digest] Mar 23, 2020 - Mar 29, 2020
- [Weekly Digest] Mar 30, 2020 - Apr 5, 2020
- [Weekly Digest] Apr 6, 2020 - Apr 12, 2020
- [Weekly Digest] May 4, 2020 - May 10, 2020
- [Weekly Digest] Jun 1, 2020 - Jun 7, 2020
- [Weekly Digest] Jun 8, 2020 - Jun 14, 2020
- [Weekly Digest] Jul 27, 2020 - Aug 2, 2020
- [Weekly Digest] Mar 1, 2021 - Mar 7, 2021
- [Weekly Digest] Mar 1, 2021 - Mar 7, 2021
- [Weekly Digest] Mar 8, 2021 - Mar 14, 2021
- [Weekly Digest] Mar 8, 2021 - Mar 14, 2021
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ledger-transport.