Centre Button Selectable Conflicts with Custom Icon

[armcha]

Centre Button Selectable Conflicts with Custom Icon

[Kogoro]

Its an or clause. It checks whether IconColorFilter is enabled or the centreButton is selectable.
What is your use case for this behaviour?

[rayliverified]

Hi @Kogoro, thanks for the reply. I am using the centre button as my main app screen. This means the centre button should be selectable with none of the other buttons selected. However, I would also like to disable color filtering because it interferes with other images in my app. Currently, setting the centre button as selectable forces the user to use a color filter as setting color filter to false has no effect.

[Kogoro]

But should you not provide some feedback when clicking the centrebutton? I mean we could change it to an And that should solve this problem. Then the color would not change to white in default when selected. I try to do this in the next days when I'm free.

[rayliverified]

Hmm, that is an interesting problem. Do you mean that there will be no ripple effect if a custom icon is used?

[Kogoro]

In the actual implementation, the icon will get an inactive color. The reason is that the icon should indicate the active page. The inactive color can be set with inactive_centre_button_icon_color, the active color with active_centre_button_icon_color.

When you disable the IconColorFilter and we change the code to an And, the icon will have the standard icon color defined by the image at the first start. After a selection of the centreButton it is normal again when isSelectable=true.

Hope that clears your question. ;)

[rayliverified]

Issued #48 fixes this. Thanks @Kogoro for answering my questions. Closing!

[Kogoro]

@searchy2 This only affects the color which is set at the beginning. It will not change the behavior between iconcolorfilter and centrebuttonselectable.