Giter Site home page Giter Site logo

Comments (8)

chrisbarnes avatar chrisbarnes commented on July 28, 2024

@GerritKuilder Can you provide a little more detail for this one?

from wordpress-bootstrap.

GerritKuilder avatar GerritKuilder commented on July 28, 2024

If you try to set up a child theme with this theme you get a few errors:

require_once([...]\wordpress/wp-content/themes/bootstrapChild/admin/options-framework.php

See http://codex.wordpress.org/Function_Reference/get_stylesheet_directory
http://codex.wordpress.org/Child_Themes
a child theme has the advantage of making additional changes to a theme without the need to modify the original code.

Also the style.css of a child theme is used to pull in the theme css's and I think at the moment this does not happen.

I don't know how it will work in regards in pulling in lib stuff if they are also in a child theme.

I think it is best I make a separate wordpress setup for this and see how far I can get.

from wordpress-bootstrap.

GerritKuilder avatar GerritKuilder commented on July 28, 2024

Looked at the latest download and had issues with the admin part:

changed code: in options-framework.php, the only way to get it to work.

if ( STYLESHEETPATH == TEMPLATEPATH ) {
define('OPTIONS_FRAMEWORK_URL', TEMPLATEPATH . '/admin/');
define('OPTIONS_FRAMEWORK_DIRECTORY', get_bloginfo('template_directory') . '/admin/');
} else {
define('OPTIONS_FRAMEWORK_URL', STYLESHEETPATH . '/admin/');
define('OPTIONS_FRAMEWORK_DIRECTORY', get_bloginfo('template_directory') . '/admin/');
}
require_once (get_template_directory() . '/admin/options-framework.php');

Changed the header.php: lots of styles (css/js) where hardcoded to the template directory. For child themes this is not very convenient. Most styles use only wp_head function and add_action(wp_head,....).
Could not find the details..... but most likely doe some clever stuff to see if a child theme is used and/or files exist.

As the bootstrap.css set some backgrounds it would be convenient to be able to override all css/js etc in a child theme. (although a better solution would be to import them in child/style.css)

header.php:


Site: devel.kuilder.net/bootstrap

from wordpress-bootstrap.

Synchro avatar Synchro commented on July 28, 2024

I've run into this too. For now I've worked around it like this:

  • Created symlinks to the admin and library folders in the master theme in the child folder
  • Changed this in Header.php:
    <link rel="stylesheet" href="<?php bloginfo('stylesheet_url'); ?>">
    
    
Then imported the master style sheet from inside my child theme's style.css.
This is all very hacky though, not a proper fix!

from wordpress-bootstrap.

chrisbarnes avatar chrisbarnes commented on July 28, 2024

Please have a look at the latest commit and let me know how things work.

from wordpress-bootstrap.

Synchro avatar Synchro commented on July 28, 2024

I've confirmed that it now works as a child theme, without the symlinks I created before. This is great as it now means I can just git pull in the master theme folder and not worry about breaking anything. Thanks for pushing the fix.

from wordpress-bootstrap.

chrisbarnes avatar chrisbarnes commented on July 28, 2024

@Synchro Great news! Please let us know if you see any issues.

from wordpress-bootstrap.

GerritKuilder avatar GerritKuilder commented on July 28, 2024

So far So Good, nice

from wordpress-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.