Giter Site home page Giter Site logo

Comments (4)

Arnavion avatar Arnavion commented on June 17, 2024

It's documented, but admittedly not in a place where you'd look. https://github.com/Arnavion/derive-error-chain/blame/741135fc0ef00b204e6661eb283ead6e28fc7fb3/CHANGELOG.md#L60

Making error-chain a dependency of this crate will not work. It needs to be a dependency of the crate where the macro is invoked.

from derive-error-chain.

reuvenpo avatar reuvenpo commented on June 17, 2024

I see...
I think it's a good idea to put it somewhere near the top of the documentation. It's a pretty important, non-trivial detail (and i spent an hour before i figured it out...)

Is it possible/desirable to lose that dependency? or would that both break compatibility with error_chain and be too much of a hassle?

(of course, the saner alternative is to just document the dependency :P)

from derive-error-chain.

Arnavion avatar Arnavion commented on June 17, 2024

Using error-chain's traits is a deliberate decision. #5

from derive-error-chain.

reuvenpo avatar reuvenpo commented on June 17, 2024

That makes sense.

(Thanks for the cool package, btw :) )

from derive-error-chain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.