Comments (2)
I understand that SimplePromise is a little different from SimpleSet and SimpleMap in that it's exposed more openly from the libjass API, whereas the other two are used completely internally. However I don't want to make the shim more complex than libjass itself needs it to be internally.
libjass only uses SimplePromise if global.Promise is not defined. If you want the promises that libjass's API returns to have more features, then you should give it such an implementation yourself, say, by including bluebird. For the same reason, if the browser / runtime has a native promise implementation, libjass will automatically use that.
If for whatever reason you're unable to have global.Promise be available for libjass to use at the time you load it (say your implementation is loaded after libjass is, or say it doesn't assign itself to global.Promise), you can still override the promise implementation used by libjass by setting libjass.Promise, eg: libjass.Promise = require("bluebird");
Make sure you do this before using any libjass API that returns you a promise, since I do not guarantee that an instance of SimplePromise works with instances of any other type of Promise.
from libjass.
This was fixed by 71151b2
Regarding:
Make sure you do this before using any libjass API that returns you a promise, since I do not guarantee that an instance of SimplePromise works with instances of any other type of Promise.
Since SimplePromise follows the Promises/A+ spec correctly, it should in fact work with instances of other types of Promise.
The recommendation to use a more featured and performant library still stands.
from libjass.
Related Issues (20)
- "PlayResX" is not treated as optional! -> breaking HOT 15
- When PlayResX or PlayResY are defined as zero, tab crashes. HOT 1
- Unexpected style margin collisions HOT 1
- \n being rendered in plain text, wrapping style 2 HOT 2
- Request for new release HOT 2
- How to crate subtitle from JSON Object ? HOT 2
- libjass.deserialize dialogue style changes not work HOT 2
- When playing preroll ads, sometimes the text appears very small HOT 1
- Why the npm package doesn't contains a type definition file. HOT 1
- Line-specific styles do not override style definitions HOT 2
- \fad with a fadeout of 0 is treated as fading out for the duration of the line HOT 1
- Opt-in support for command execution HOT 3
- [Feature Request]Can you convert a .ass subtitle to VobSub format? HOT 2
- dialogues ID will be created next to the last dialogues ID from previous object HOT 3
- when I create new dialogue can I get a dialogue class tag? HOT 1
- Update Typescript version HOT 6
- Serialize back to .ass HOT 1
- implement smart line wrapping
- Lines can be "pushed away" by other lines on the same layer HOT 2
- Lines are moved down when lines underneath it are removed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libjass.