Giter Site home page Giter Site logo

External Links Don't Open about sidr HOT 2 CLOSED

artberri avatar artberri commented on May 21, 2024
External Links Don't Open

from sidr.

Comments (2)

phatsk avatar phatsk commented on May 21, 2024

Suggesting a patch:

--- sidr.js 2013-05-29 13:01:44.000000000 -0400
+++ sidr.custom.js  2013-05-29 13:02:27.000000000 -0400
@@ -185,7 +185,8 @@
    side          : 'left', // Accepts 'left' or 'right'
    source        : null,   // Override the source of the content.
    renaming      : true,   // The ids and classes will be prepended with a prefix when loading existent content
-      body          : 'body'  // Page container selector,
+      body          : 'body', // Page container selector,
+      honoranchors  : false   // Honor <a> tags
    }, options);

    var name = settings.name,
@@ -250,7 +251,9 @@
    if ( ! data ) {
        $this.data('sidr', name);
        $this.click(function(e) {
-          e.preventDefault();
+          if(!settings.honoranchors) {
+           e.preventDefault();
+         }
        methods.toogle(name);
        });
    }

from sidr.

artberri avatar artberri commented on May 21, 2024

I think you are not using it properly, or maybe I do not understand you. The links works perfectly inside the Sidr, the preventDefault is for the clicking in the button/link that will open the Sidr menu.

from sidr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.