Giter Site home page Giter Site logo

Comments (11)

raxemus avatar raxemus commented on July 18, 2024

Approve =)

from android-wail-app.

nasa42 avatar nasa42 commented on July 18, 2024

And doing so right from the notification drawer would be awesome. :-)

from android-wail-app.

artem-zinnatullin avatar artem-zinnatullin commented on July 18, 2024

Notifications is great idea! Also should be presented in the Tracks list
and may be on Main screen for currently playing track :)

You guys are awesome!
26 авг. 2014 г. 12:17 пользователь "Vikrant Chaudhary" <
[email protected]> написал:

And doing so right from the notification drawer would be awesome. :-)


Reply to this email directly or view it on GitHub
#43 (comment)
.

from android-wail-app.

raxemus avatar raxemus commented on July 18, 2024

Wait to see the tracks notifications, like have the original client - and the prices no was would for that application 👍 ^_^

from android-wail-app.

ilya-murzinov avatar ilya-murzinov commented on July 18, 2024

Well, it's great :)
I'll probably start with main screen, because it's the simplest to implement.

from android-wail-app.

ilya-murzinov avatar ilya-murzinov commented on July 18, 2024

@artem-zinnatullin, @raxemus, @nasa42
Hi guys, I implemented most of the functionality, but I want to discuss details.
What I now have is working "Love" button on main screen and on notification (if it's turned on).

The question is what style of these buttons we want to have and how to notify user that track is "loved". Right now the button is standard android button and it makes a toast saying "Track loved :)" when clicked.

Problems are:

  • It looks ugly :)
  • User can "love" one track arbitrarily many times. But official scrobbler also have this problem, may be it's not really the issue
  • When clicking "love" button on notification, toast is (may be partially) hidden behind notification drawer so user may not understand that it works right

Any thoughts?

from android-wail-app.

artem-zinnatullin avatar artem-zinnatullin commented on July 18, 2024

Wow, great!

I think, it's better to use some free licensed "heart" icon for the button and show description toast for it on long click.

About the problems:

  • Icon can be good :D
  • It's okay, though we can not get any track id and we can not get track's "love" state before the action
  • "Love track" from notification can produce new ongoing notification "Loved track: track_name" and it will be definitely visible and understandable for users :)

from android-wail-app.

ilya-murzinov avatar ilya-murzinov commented on July 18, 2024

Found this one here. It's under Creative Commons (Attribution 3.0 Unported) License (Free to use and/or modify).
heart

from android-wail-app.

artem-zinnatullin avatar artem-zinnatullin commented on July 18, 2024

Looking good :)

from android-wail-app.

ilya-murzinov avatar ilya-murzinov commented on July 18, 2024

Done, closing.

from android-wail-app.

artem-zinnatullin avatar artem-zinnatullin commented on July 18, 2024

Awesome

from android-wail-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.