Support for back/forward keys (typically mouse button 4/5)

[artemanufrij]

Support for back/forward keys (typically mouse button 4/5)

[artemanufrij]

@jlnr currently you can do that by press + LEFT/RIGHT. But I think your suggestion is very useful. Give me a moment 👍

[artemanufrij]

@jlnr in my case they are 8/9

[artemanufrij]

@jlnr could you test current master branch please?

[jlnr]

Wow, that was quick :) Right now mkdir build && cd build && cmake .. is choking on this:

CMake Error at CMakeLists.txt:27 (include):
  include could not find load file:

    ValaPrecompile


CMake Error at CMakeLists.txt:28 (find_package):

Edit: Never mind, I was missing the cmake-elementary package.

[jlnr]

Back works, forward doesn't.

[jlnr]

I've just looked at the source code and I wonder if my mouse is to blame. I had to remap my fifth mouse button to XF86Forward using command-line magic because by default it is mapped to something silly. This mapping works fine throughout elementaryOS, including Epiphany, but maybe it's throwing off the JavaScript button numbers?

Edit: I've connected another mouse and both back (physical button 4) and forward (physical button 5) work. I'm fine with closing this issue and just blaming the broken forward key on my mouse setup.

[artemanufrij]

@jlnr I don't know... I use some Logitech and Dell mouse devices without modifying it. And it works fine in all browsers and other apps like Files. 🤷‍♂️

[jlnr]

Ah, got it. Mice usually send button 8/9. However, there are also Gdk key constants for Back/Forward navigation (for monstrosities like this - I think I might've owned this one before, I remember having these keys), and that's what I've mapped my mouse button to.

So if I add this in addition to the button_press handler, everything works for me:

            web_view.key_press_event.connect ((event) => {
                if (event.keyval == Gdk.Key.Back) {
                    web_view.go_back ();
                    return true;
                } else if (event.keyval == Gdk.Key.Forward) {
                    web_view.go_forward ();
                    return true;
                }
                return base.key_press_event (event);
            });

Obviously I should also reconsider the way I've mapped my mouse button 😅, but as the rest of elementary apparently understands the navigation Gdk.Keys, I would still suggest adding the above code.

[artemanufrij]

let me try it...

[artemanufrij]

@jlnr Gdk.Key.Back doesn't work. Its value is 269025062 😕

I guess it means keyboard key and not mouse button

[jlnr]

Yes, I had to set the key_press_event handler in addition to button_press_event (from your commit).

[artemanufrij]

I see.. good point! I pushed it into current master

[jlnr]

Great, thanks!

[artemanufrij]

@jlnr thank you for your support! New release is waiting for approve...