Giter Site home page Giter Site logo

Comments (7)

fancyremarker avatar fancyremarker commented on June 29, 2024

Hi @andyw8, yes, converting to a String would be one way to work around this. At the core of this issue is the fact that ActiveSupport::Cache::Store doesn't support serializing StringIO objects. Off the top of my head, I think the only way we would solve this in Garner would be to detect cache objects of type StringIO, and then:

  1. Call read on the object before storing.
  2. Annotate the cache object to indicate that it was originally of type StringIO (something we don't do currently).
  3. Re-wrap the cached string in a StringIO object on fetching.

I couldn't find much on the topic, but the fact that ActiveSupport::Cache::Store doesn't do this by default leads me to believe it might not be prudent.

An alternative is to only cache the product = Product.find params[:id], and to present the product outside the cache block. But this would incur the cost of re-presenting on each request.

from garner.

dblock avatar dblock commented on June 29, 2024

We could also build support for StringIO when defined in Garner proper within the Grape extension. So this issue can be renamed to "support Grape Entity presenters". I think it would be as simple as checking that the type is StringIO and calling to_s on it.

from garner.

fancyremarker avatar fancyremarker commented on June 29, 2024

Going to close and mark this one wontfix, since Garner v0.4.0+ defers this sort of decision to the underlying cache/marshaling implementation.

from garner.

andoriyu avatar andoriyu commented on June 29, 2024

So what is the work around this?

from garner.

dblock avatar dblock commented on June 29, 2024

@andoriyu It depends on your scenario. If you have a StringIO in the garner block, add a to_s to it, for example.

from garner.

andoriyu avatar andoriyu commented on June 29, 2024

I figured it out. Maybe makes sense to add this to documentation:

            garner.bind(@song) do
              song = present @song, with: ::AdminSongPresenter
              song.as_json
            end

from garner.

dblock avatar dblock commented on June 29, 2024

I'd welcome any README change that makes sense :)

from garner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.