Giter Site home page Giter Site logo

Comments (3)

arauschert avatar arauschert commented on June 25, 2024

Hi,

thanks for your feedback!

Regarding question 1:
Here, we have three entityRefs defined in the story. The first one is the Actor for the actions. The other two are for calculation of the relative longitudinal distance. If you use the road coordinate system (new in OSC 1.1; in OSC 1.0 it was not defined) for distance calculation, then you're right that switching these two would be also correct and result in the same execution behaviour. If you use the lane coordinate system (also OSC 1.1, we are updating the moment), which is more accurate, you would want to measure the distance on the lane of the ego vehicle, so from Ego to CutInVehicle. The annotation in OpenSCENARIO 1.1 for RelativeDistanceCondition is as follows: "The current relative distance of a triggering entity/entities to a reference entity..."
Therefore you would need to have the Ego as TriggeringEntity. So, no change is needed. But still thanks for the hint, I didn't check this in detail yet.

Regarding question 2:
You're right, the unit for deceleration in the SpeedAction is m/s², so it's the rate (default value is 6 m/s² and not 6 g). The name "Gx max" was taken from the ALKS regulation, so the transfer from regulation to scenario is easier, but I will change the naming of the parameter to LeadVehicle_Deceleration_Rate. It's not 100% clear what are the test requirements because in chapter 4.3.2 of the regulation a minimum of 6 m/s² is mentioned as rate, while in chapter 5.4 "-1.0" G is mentioned.
With the update to OpenSCENARIO 1.1 and the use of expressions we can then also use g as unit for the parameter with values between 0 and 1 and calculate the rate for the SpeedAction (rate = $LeadVehicle_Deceleration_g * 9.81), which is the more strict requirement.

from osc-alks-scenarios.

tmIdiada avatar tmIdiada commented on June 25, 2024

Hi,

thank you for the answers, regarding point 1 I was too concentrated on straight roads, but in case of curved roads you are right, that then there is a difference in the distance.

I have found a small inconsistency in case of CutOut scenario, there is it called CutOutManeuverGroup, instead of the used CutInSequence or BrakeSequence in the other 2 scenarios, but not really important.

The more important additional issue is, why there is defined an acceleration action for cut-in vehicle, have you found some information in the regulation or comes it directly from your side and that is the reason for rate 0? If one uses here rate 0, then one can also delete this whole acceleration action, right?

from osc-alks-scenarios.

arauschert avatar arauschert commented on June 25, 2024

Thanks for the additional hints!

I renamed ...Sequence to ...ManeuverGroup now. I missed this when updating from OSC 0.9.1, where ManeuverGroups were called Sequences.

Regarding the accerleration in cut-in: You're right that when using rate 0, the action could also be removed. In chapter 4.4.3 (b) of Annex 5 acceleration and deceleration are mentioned for the Cut-In scenario, therefore the action was added in the OSC scenarios. But in Annex 4 chapter 4.3, deceleration is not mentioned as parameter for cut-In. Therefore I set the rate to 0 for testing according to the attached data sheets.

from osc-alks-scenarios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.