Giter Site home page Giter Site logo

Comments (4)

marcogallotta avatar marcogallotta commented on September 13, 2024

This is a good suggestion. It might be best for our methods to take requestOptions and add them all as parameters to request. This would allow people to configure proxies, # of http agents, or anything else.

We aren't going to prioritise this right now, but would gladly accept a PR if you're interested in contributing.

from node-asana.

harshu108 avatar harshu108 commented on September 13, 2024

I would gladly do it for you, just need little context about how you want to get it done...Your design is little complicated, a little context would help.

Also need to know, how long will it take to close the pull request and incorporate the changes?

from node-asana.

slobak avatar slobak commented on September 13, 2024

The design is meant to make it easy to apply options to all request by default while still preserving the flexibility and forward-compatibility to support other options, or per-request overrides.

Protocol-related things like this should follow this pattern, and thus they should be part of the configuration of the Dispatcher. If you look at the Dispatcher constructor you'll see it takes options, which it then uses in its dispatch method to configure the params passed to request. So I'd recommend adding another option to dispatcher for this, and using it in the appropriate place. Follow the model of the other options there.

Is that enough to go on?

from node-asana.

cw-sebastian avatar cw-sebastian commented on September 13, 2024

Also need this feature.
Pull request is on its way :)

from node-asana.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.