Comments (4)
This is a good suggestion. It might be best for our methods to take requestOptions
and add them all as parameters to request. This would allow people to configure proxies, # of http agents, or anything else.
We aren't going to prioritise this right now, but would gladly accept a PR if you're interested in contributing.
from node-asana.
I would gladly do it for you, just need little context about how you want to get it done...Your design is little complicated, a little context would help.
Also need to know, how long will it take to close the pull request and incorporate the changes?
from node-asana.
The design is meant to make it easy to apply options to all request by default while still preserving the flexibility and forward-compatibility to support other options, or per-request overrides.
Protocol-related things like this should follow this pattern, and thus they should be part of the configuration of the Dispatcher
. If you look at the Dispatcher
constructor you'll see it takes options, which it then uses in its dispatch
method to configure the params
passed to request
. So I'd recommend adding another option to dispatcher for this, and using it in the appropriate place. Follow the model of the other options there.
Is that enough to go on?
from node-asana.
Also need this feature.
Pull request is on its way :)
from node-asana.
Related Issues (20)
- typescript definitions - howto HOT 3
- Deploy new version on npm HOT 3
- "Property 'getTasks' does not exist on type 'Tasks'. Did you mean 'getTask'?" but WHY?? HOT 2
- Resource `Goals` is not exported?
- Module can't be built in `create-react-app` project because of missing polyfills in webpack >5
- The `Asana.auth.PopupFlow` does not work HOT 1
- Project Templates missing HOT 1
- webhooks.create vs webhooks.createWebhook HOT 1
- deprecated dependency: request
- Response from a request is asking to authorize application HOT 1
- client.tasks.findAll deprecation HOT 1
- html_notes undefined with getTask(gid) with opt_fields HOT 1
- client.tasks.create with a custom field creates 2 tasks
- 'created_by' property is missing from returned data HOT 2
- Missing changelog HOT 6
- Oauth2 replies 400 with no useful error message HOT 1
- types HOT 1
- Adding a task named `Ads` breaks the frontend HOT 1
- Bug: Task Templates API not reflecting any updates after creation HOT 1
- Property 'ApiClient' does not exist on type 'typeof asana'. Did you mean 'Client'?ts(2551) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-asana.