Separate embedder and encoder in flambe.nn.embedder

[cle-ros]

Separate embedder and encoder in flambe.nn.embedder

[jeremyasapp]

I don't know if this use case legitimizes changing the interface.. You could just create a new Embedder-style object for you use case. Could you provide an example or two so we can better understand the motivation?

[cle-ros]

NLP models that do sequence comparison (the NLI groups comes to mind) are oftentimes implemented with a different encoder object for each compared part. In these cases, the standard flambe implementation will instantiate not only two encoders, but also two embedders - which, again, can result in a waste of GPU memory as embedding matrices can be huge.

[jeremyasapp]

Ok this use case makes sense, but I don't understand the change you are requesting. Embedding and encoder are already separated. Embedder links both of them, so you could very easily create a different embedder with two encoders?