The official version of Zhongwen works on Android

[ascemama]

The official version of Zhongwen works on Android

[ascemama]

Hi Christian, I understand your point and I would have no problem removing the zhongwen-android addon from the firefox android store when zhongwen does what zhongwen-android do. I really don't want to steal your project, my goal is just to have a zhongwen version that works on Android because it is how I learn chinese. I use your version on my laptop firefox which works great by the way :) I just tried again to install zhongwen on my android device (sony xperia), it does not work. Specifically, I installed it and I can go to the config page, but when I am browsing a chinese website and touch a character with my finger no pop up comes up.   When I look at the code the only event handlers I see are OnMouseMove and OnKeyDown so I don't see how Android events can be handled. To me it seems Android is still not supported..  Frankly, for me the Android version can't have many feature because the screen is just too small.  I just want it to be able to give me the english translation of a character so I don't plan to do any update and I don't care if it run on an old version of your code base.  Also I had to change quite  a lot of things from the firefox version to make it work, this is why I thought it makes more sense to have another project for the android version instead of just a different branch. If you work on the android version I am happy to test it and give you feedback. If you don't maybe we can cooperate later this year (after summer) to work on a pull request. Thx,Antoine  On Saturday, May 9, 2020, 06:41:49 PM GMT+8, Christian Schiller <[email protected]> wrote: Hi, I'm the original creator of the Zhongwen Chrome extension. I wanted to point out that the latest version of Zhongwen for Firefox does support Android devices. https://addons.mozilla.org/en-US/firefox/addon/zhongwen/ As of version 5 Zhongwen uses the same codebase for Chrome and Firefox. You can find the repository here: https://github.com/cschiller/zhongwen The Firefox specific code is contained in the branch "firefox". If you want to contribute to the Firefox version I would suggest to use the codebase from the official repository above. Right now there are too many versions of Zhongwen on the Mozilla Add-ons site: - Zhongwen: The Popular Chinese Learning Tool (the official version supported by me) - Zhongwen: Chinese-English Popup Dictionary (Leonard Lausen's version built on an obsolete version, which is no longer being supported) - Zhongwen: Chinesisch-Deutsch Wörterbuch (Leonard Lausen's port of a German version that I created for Chrome, also built on an obsolete version) - and now your zhongwen-android I think this situation is really unfortunate and confusing for users, who still download old unsupported version for Firefox instead of the latest version from the 5.x development branch. Could you try out the official version for Firefox on your Android device and let me know if it works for you? https://addons.mozilla.org/en-US/firefox/addon/zhongwen/ Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[cschiller]

Hi Antoine,
I tested my own Firefox version of Zhongwen and it does work on my Android device, so I'm not sure why it's not working for you. Maybe it's because you have both versions installed (yours and mine) and this is causing problems?

The 5.x version of Zhongwen is a major rewrite of the old code, so I have made a lot of changes to and fixed a number of bugs that were in the old 4.21 code your version is based on.

I would really appreciate if you work with my Firefox version. Believe me, it does work. :) If there's a problem on your device I'm sure we can fix it. So if you make any changes you can just create a pull request for me.

I have no objections if you use your version on your device, if you prefer. But I would kindly ask you to remove it from the Mozilla Add-ons site. It's just too confusing for users to have all these versions and not know which is which. You can sideload it to your device and need not upload it to the Mozilla site. If you do not want to remove it then at a minimum you need to rename it and change the icon so it is clear that your version is a fork with different functionality and a different name. The reason for this request is that the current situation with all these mushrooming Zhongwen versions is too confusing for users.

Thanks!

[cschiller]

[cschiller]

I attached two screenshots from my Android device to prove that my version works on Android. :)

https://github.com/cschiller/zhongwen/tree/firefox

[cschiller]

One important note: As with the desktop version you need to activate the extension first by tapping on the extension name (there's no icon for the extensions as in the desktop version of Firefox, but the extensions are listed at the bottom of the menu that opens when you tap on the three dots in the upper right-hand corner of the browser). I think this is why it didn't show you the translations.

[ascemama]

Hi Christian, ok my bad, I did not know that you need to activate it by tapping on it in the menu. And I did not know that such thing even exist for Android. Now it works! Maybe you could write that in the description in the Android fFirefox store as I may not be the only one to not realize that. Your Android version seems to work well however I miss one important feature that I added to my version. If configured in the menu, you can have the "pleco" icon appearing in the popup (see attachment), by clicking on it you are redirected to pleco for this word. it is much more convenient than having to change app, open pleco and search for the word manually. Personally I use this feature on a daily basis and I feel other users would have that need to.   This is what I suggest:1.   I already updated the addon description page and github of zhongwen-android and wrote that your version supports android and should be preferred except for those (like me) who need the "open in pleco" feature2. If you agree to put this feature in your addon, then you or I can work on a pull request. it should be quick to implement.3. Once this feature is released I will remove the zhongwen-android addon from the firefox store. Do you agree ? Thx,Antoine On Monday, May 11, 2020, 04:29:06 PM GMT+8, Christian Schiller <[email protected]> wrote: One important note: As with the desktop version you need to activate the extension first by tapping on the extension name (there's no icon for the extensions as in the desktop version of Firefox, but the extensions are listed at the bottom of the menu that opens when you tap on the three dots in the upper right-hand corner of the browser). I think this is why it didn't show you the translations. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[cschiller]

Sounds good. I think having the Pleco link is really useful, so let's make it part of the official version.

[Wainhouse]

I cannot access this on android, please can you add it to android again?

[jamesmurdza]

Hello, I can confirm that there are no available Zhongwen extensions in the Firefox for Android store.

@cschiller On your extension's official page the button is grayed out and only the message "To find add-ons compatible with Firefox for Android, click here."

Would be great if we could get this back!

[ascemama]

@jamesmurdza @Wainhouse : since 2020 it is not possible anymore to freely develop and distribute and install Firefox Android Extension. Currently it is only possible to distribute/install "recommended" Extension made by big brands. It has to do with a refactoring of the Firefox code base: https://extensionworkshop.com/documentation/develop/developing-extensions-for-firefox-for-android/
When it is possible again, I am sure @cschiller, me or someone else will work on this.

[jamesmurdza]

@ascemama Thank you for the reply and explanation on the restrictions. Maybe users that are motivated to make this work on mobile devices wouldn't mind changing browsers (I wouldn't.) so I opened an issue in the Chrome extension repo: cschiller/zhongwen#92

It would be great to have any combination of browser and extension that can work on mobile!

[ascemama]

@jamesmurdza : On chrome it was never possible to have mobile extension, excepted a few recommended one. AFAIK there is currently no browser which support extension development for the mass. If you find one, let me know.

[jeffrytambari1]

Hello @cschiller & @ascemama, I would like to inform my try to run Zhongwen in mobile Android/iOS using PWA. Here is my repo: https://github.com/jeffrytambari1/zhongpwa

Thx