Skia build failing (MacOS 12.3)

[aseprite]

Skia build failing (MacOS 12.3)

[ryandesign]

In macOS 12.3, Apple removed /usr/bin/python. Perhaps because of this, or for other reasons, you might have created your own python symlink pointing to a version of python 3. If you do this, the find_xcode_sysroot.py script, which is part of the skia build, does not work correctly. Here is an example of the script working correctly with python 2:

$ python2 skia/gn/find_xcode_sysroot.py macosx
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk

Here is an example of the script working incorrectly with python 3:

$ python3 skia/gn/find_xcode_sysroot.py macosx
b'/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk\n'

You can see the result of the wrong script output in the portion of the log you posted where it says:

-isysroot b\'/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk\\n\'

Since this isn't valid syntax for the -isysroot flag, this causes the subsequent failure to find the files that are in the SDK:

../../third_party/externals/libwebp/src/utils/random_utils.c:14:10: fatal error: 'string.h' file not found 

The workaround for the problem would be to ensure that your python symlink points to a version of python 2, not python 3.

The fix would be to rewrite find_xcode_sysroot.py so that it returns the correct output under python 3. This was already done in this upstream commit: google@7bc4c9a

diff --git a/gn/find_xcode_sysroot.py b/gn/find_xcode_sysroot.py
index be5b687e0390..e514271bc391 100755
--- a/gn/find_xcode_sysroot.py
+++ b/gn/find_xcode_sysroot.py
@@ -12,4 +12,5 @@
 
 (sdk,) = sys.argv[1:]
 
-print(subprocess.check_output(['xcrun', '--sdk', sdk, '--show-sdk-path']))
+print(subprocess.check_output([
+    'xcrun', '--sdk', sdk, '--show-sdk-path']).decode('utf-8'))

Similar changes are made to other scripts in that commit.

Perhaps the aseprite fork of skia could be updated to include that commit.