Comments (4)
Hey @andrey-helldar, thanks for flagging this up. I mainly intended for the package's migrations to only create the structure of the tables so that the dev using the package can have more granular control themselves. Of course, if you wish to add indexes to the tables, you can publish the migrations and add them yourself manually
from short-url.
It is strange for me to force other developers to make changes to the functionality of the package.
In addition, there are many newbies in our industry who don't even know how indexes work.
That is why I suggested changing the package code.
The indexes I found are critical when searching and must be, but now the responsibility for creating them needs to be shifted to others...
However, good luck!
from short-url.
I'll do a bit of reading into this and check across other packages as well to see what the convention is for this type of thing. If it's looking like some of the other mainstream packages also add indexes to their migrations, I think it'd be good to get them added.
If you'd like to contribute, feel free to make a PR
from short-url.
I trust you
from short-url.
Related Issues (20)
- Ability to get existing instead of creating new one
- single_use and deactivated_at HOT 3
- singleUse and Multiple use
- Expire Short Links Remove
- Default Tracking set False
- Add support for bulk data
- Embracing Testing HOT 8
- Is there possibility to add user_id to the short_urls table and populate that if user is authorized?
- How to disable link? HOT 1
- Short URL redirect not working HOT 3
- Link Clicked Events not being "caught" by Listener HOT 4
- A short URL with this key already exists. HOT 1
- Manually rerun migrations HOT 4
- Issue with config('short-url.default_url') HOT 6
- Using a Custom Route not working HOT 2
- [FR] make it possible to overwrite the models
- Whitelisting IPs HOT 1
- Gives 404 if prefix is null HOT 8
- Click even t(ShortURLVisited) only registering once on live HOT 3
- Duplicate entry for key HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from short-url.