Giter Site home page Giter Site logo

Comments (4)

ash-jc-allen avatar ash-jc-allen commented on September 7, 2024

Hey @andrey-helldar, thanks for flagging this up. I mainly intended for the package's migrations to only create the structure of the tables so that the dev using the package can have more granular control themselves. Of course, if you wish to add indexes to the tables, you can publish the migrations and add them yourself manually 😄

from short-url.

andrey-helldar avatar andrey-helldar commented on September 7, 2024

It is strange for me to force other developers to make changes to the functionality of the package.

In addition, there are many newbies in our industry who don't even know how indexes work.

That is why I suggested changing the package code.

The indexes I found are critical when searching and must be, but now the responsibility for creating them needs to be shifted to others...

However, good luck!

from short-url.

ash-jc-allen avatar ash-jc-allen commented on September 7, 2024

I'll do a bit of reading into this and check across other packages as well to see what the convention is for this type of thing. If it's looking like some of the other mainstream packages also add indexes to their migrations, I think it'd be good to get them added.

If you'd like to contribute, feel free to make a PR 😄

from short-url.

andrey-helldar avatar andrey-helldar commented on September 7, 2024

I trust you 😁

from short-url.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.