Comments (6)
Possibly also relevant, we internally altered the constructor a bit due to the structure of Faraday::TimeoutError
module Graphlient
module Errors
class FaradayServerError < ServerError
# Overriding this constructor. Timeout errors do not have a `response` member, thus we get NoMethodError on [].
def initialize(inner_exception)
super(inner_exception.message, inner_exception)
@inner_exception = inner_exception
return unless inner_exception.response.present?
@response = inner_exception.response[:body]
@status_code = inner_exception.response[:status]
end
end
end
end
from graphlient.
Thanks @BenDrozdoff for reporting this 💜. Feel free to open a PR with your change or I'll try to get to this during holidays.
from graphlient.
NP, looks like the error I was seeing was pretty similar to #68 just with a different Faraday Error class.
from graphlient.
from graphlient.
slack-ruby/slack-ruby-client#309
from graphlient.
Hi guys, sorry if this caused some pain, that was an involuntary change.
I'm fixing this so that the change in hierarchy will be reverted.
Looking at your code, it doesn't seem like you'll need to change anything, but I'd suggest you keep the changes you've done since the changes on our side will come back in Faraday 1.0.
This way you'll be one step closer to upgrading when the time comes 😄
from graphlient.
Related Issues (20)
- cannot stub request anymore HOT 11
- Unable to pass literal values / constants in Ruby HOT 3
- Getting error - After upgrading rails from 5.2.8 to 6.1.7 HOT 3
- [FEATURE] Expose underlying HTTP response HOT 1
- Custom type name lookup not working HOT 2
- How to pass context in query? HOT 14
- Dynamically change headers HOT 2
- Don't know how to pass custom input types HOT 2
- Mutation HOT 11
- disable schema dump HOT 3
- How to stub with webmock HOT 12
- Latest version incompatible with faraday 1.0.0 HOT 8
- Camelcasing => ClientError between 0.3.3 & 0.3.7 HOT 4
- Cache Faraday::Connection and use Faraday::Adapter::NetHttpPersistent
- How to query without a schema? HOT 2
- Are union types supported using block syntax? HOT 1
- Possibility of dynamically adding fields to a query? HOT 3
- Docs incorrectly state that Graphlient::Errors::TimeoutError does not inherit from Graphlient::Errors::ServerError HOT 3
- Enable the use of FragmentDefinition constants within blocks HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphlient.