Asscroll + Highway.js

[paullangton]

Asscroll + Highway.js

[ashthornton]

It looks like you're initialising a new ASScroll instance every time onEnterCompleted() is run. You want to have only one instance which you then call enable() and disable() on.

There's various ways of setting up a Highway renderer to run code only once on site load, but the easiest way might be to make the ASScroll instance outside of your renderer:

const asscroll = new ASScroll()
const highway = new Highway()

[ashthornton]

Hey @paullangton could you paste in your code so I can see exactly what you're doing? As in your Highway onLeave() and onEnterCompleted() functions?

I use Highway in a lot of projects and I've never encountered this problem.

[paullangton]

Of course, here is the scroll.js have simplified it, followed by the renderer.js - I've put destroy in both onLeave() and onLeaveCompleted

Note, all components are called into a components index.js and where scroll is being called into the renderer.js file this will usually inti and destroy all the ones inside the renderer html tags.

Let me know if you need anything else.

// Scroll.js
import ASScroll from '@ashthornton/asscroll'

export default class Scroll {
constructor() {
this.scroll = new ASScroll({
element: '.o-site_wrapper',
innerElement: '.o-scroll',
customScrollbar: true
});
}

init() {
	this.scroll.enable();
}

destroy() {
	this.scroll.disable();
}

}

// Renderer.js
// components
import Scroll from '../components/scroll/scroll';

class Renderer extends Highway.Renderer {
onEnter() {

    }

    onEnterCompleted() {
          this.scroll = new Scroll();
          this.scroll.init();
    }

    onLeave() {
      
    }

    onLeaveCompleted() {
          this.scroll.destroy();
    }

}

// export
export default Renderer;

[ashthornton]

You can set up a 'first load' function within a Highway renderer by overriding the setup() function in the Renderer class:

class DefaultRenderer extends Highway.Renderer {
    onFirstLoad() {
        this.scroll = new ASScroll()
        this.onEnter()
        this.onEnterCompleted()
    }

    setup() {
        this.onFirstLoad()
    }
}

I do this on every project as it gives better control over that initial site load

[paullangton]

Thanks for your reply Ash.

I thought initialising the plugin after onEnterCompleted() allowed it to re-calculate the new page height.

I'v had a quick play with the DefaultRenderer extends Highway.Renderer but just can't seem to get it to initialise again after the page transition.

First time using highway.js. So will dig a bit deeper into the docs.

I note you have a highway-kit which seems to be following what you are saying so will check that out too.

[ashthornton]

I thought initialising the plugin after onEnterCompleted() allowed it to re-calculate the new page height.

Calling .enable() re-calculates the page height by default so you don't need to re-init.

I note you have a highway-kit which seems to be following what you are saying so will check that out too.

That is pretty out-dated but I think some of the core concepts are in there.

Let me know how you get on and whether or not it fixes your original issue.

[paullangton]

Hi Ash - got it working - feel free to close this.

I just removed asscroll out of it's own scroll.js file and called it directly into my components.js file where I use the enable() and disable()

That way (as you said) i'm only creating one instance of asscroll. Has fixed the page jump.

I look further into your suggestion with the firstload. Good concept.

Thank your help and quick repsonses.

[ashthornton]

No worries @paullangton, glad you got it working :)