ashugeo/magic-maze

Online version of board game "Magic Maze"

magic-maze's Issues

TypeError thrown while moving a hero if mouse is held down and moved all over the place

1. Start a one-player game with no bots on scenario 1.
2. Click on the "Next Action" button until you get vortex.
3. Click on a hero and hold down the button and move wildly in and out of the browser window several times.
4. Open the browser debugger's console and you should see some errors.

Production:

Uncaught TypeError: o.default.get(...).isEmpty is not a function
    at e.value (bundle.js:1)
    at e.value (bundle.js:1)
    at Object.mouseMove (bundle.js:1)
    at e (bundle.js:1)

Local Development:

Uncaught TypeError: targetCell.isEmpty is not a function
    at Hero.getPath (hero.js:100)
    at Hero.checkPath (hero.js:182)
    at Object.mouseMove (events.js:301)
    at draw (user.js:90)

Create separate timer that records the time that has elapsed since the start of the game

There should be a timer that records the total in-game time and total real time (including paused time if the game was ever paused). This will let the players know how long they took to finish a scenario and could be a fun way for them to compare one run against another.

Game page won't load

Add support for scenario 8

Will need to think of the best way to present this information to the player.

Player name is incorrect if entered in multiple places

1. Player 1 starts a game.
2. Player 2 opens the website and sees player 1's game.
3. Enter in a nickname in player 1's game.
4. Click on "Create room" to create another game.
5. Fill in a room name and a different nickname in the other room.
6. Player 2 starts the new game.
7. Notice that player 2's name is the first nickname (for player 1's game) instead of the different nickname in player 2's own game.

Vortex implementation is incorrect and forces the hero to be on an existing vortex

According to the rules...

The player with the Use a Vortex action (and only this player) can move any Hero pawn from wherever it is to any Vortex space of its colour. This is a very quick way to travel long distances.

At the moment, the player with the vortex role can only move a hero from one vortex to another which is incorrect. The player should always be able to move an orange hero to an orange vortex irregardless of where the orange hero currently is.

Include play instructions in the game

Players who just open the page are not going to know what keybindings should be used for an action. We should briefly include some instructions in the game to help with this.

Allow the camera to be moved with the mouse

magic-maze/src/client/play/js/config.js

Line 7 in 96f1fab

cameraMouse: false,

I see there is a cameraMouse configuration value but setting it to true doesn't seem to do anything (besides adding errors to the browser's console).

Some ideas for moving the camera with the move:

• primary click and hold then move the mouse to pan
• secondary click and hold then move the mouse to pan
• press down on a key (such as shift or whatever) and then move the mouse to pan

Add support for scenario 16

This should just be a matter of modifying the evaluation of the vortex action.

Sometimes clock is not inverted

Hi,
first of all thanks for the app, it's fun to play.

I have one mayor issue: somtimes the item time (hourglass) is used (it get crossed) but the time is not inverted.

There are no visual clue of what is happening.

Can you advice?

Make the game touch-friendly

• it should be possible to pan the camera around with gestures
• it should be possible to zoom the camera in and out with the pinching gesture
• there needs to be additional buttons or gesture support for actions
  • explore action
  • rotating the explored tile
  • pausing the game
  • cancel action

Add support for scenario 17

This will share a bit with scenario 10 (#53) as the pawns have to stay on the tile even after they have exited the mall.

Add support for scenario 10

AI can walk through walls

When playing with bots, the AI sometimes doesn't see the wall between two tiles. This results in the AI waiting for the player to move through that wall (which is impossible for the player) or the AI moving through that wall. See the image attached for the described situation. In this image the AI will think there is a valid crossing between the lower and the upper tile.

Not that important, but when this happens the player can get stuck in the game when only playing with bots, as the bots won't let the player take another route.

Add support for scenario 15

I think we just need to remove the alert buttons from all the players here.

Support zooming with the scroll wheel on the mouse

Letting people zoom in and out with the scroll wheel should help players play faster without having to use the keyboard to zoom in and out.

Game manual?

Hi ashugeo and thank you for this game!

I had a hard time figuring out how to add a new tile. A short manual with the keyboard shortcuts would be very appreciated :)

I was also wondering: what is the status of this project? Is the game fully implemented or are some rules missing? Do you plan to work on it anymore?

I'm not an experienced web developer but I will definitely spend some time in order to understand your code and see if I can add some features.

Regards,

A French compatriote.

having problems launching this

So a friend of mine was talking about this game, she's from the Netherlands and I'd never heard of it before so I started searching online for it so we might be able to play together in the future. I found your code, but attempting to launch the server.js and watch only gets me to this screen

to get to this point I've gone into the app folder and ran npm run watch and opened a separate console window and ran node ./server.js in the same directory. Am I missing something ridiculously simple here?

Support WASD keybindings

Key	Command
S	Move map up
Z	Move map down
D	Move map left
Q	Move map right

Can we change the movement keys to be WASD like some computer games? I recognize this will mean the other keybindings will also have to change but I want to see if people are okay with this proposal first.

New tiles do not get added in other windows

I tried testing the Heroku page in Firefox and a separate incognito Firefox window. When I explore and add a tile to one window, the other window does not updated with the tile.

Show statistics screen at the end of the game

I think there can be a lot of fun statistics that could be shown at the end of the game. Here are some ideas...

• elapsed time (see #49)
• how many times the timer was flipped
• how many times the vortex was used
• how many tiles were flipped
• how many tiles were unused
• how many times a hero was moved
• how many times the "alert" was used
• how fast the "escape" portion of the game was

Tile 15 is repeated twice in scenarios 6 and 7

magic-maze/src/client/play/data/scenarios.json

Lines 18 to 23 in 14f26d0

	"6": {
	"tiles": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 15, 17]
	},
	"7": {
	"tiles": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 15, 17, 18, 19]
	}

Is this intentional? Is there something wrong with the implementation of tile 16? 🤔

Remove references to p5.js

magic-maze/src/client/play/js/camera.js

Lines 81 to 99 in 96f1fab

	if (config.cameraMouse) {
	const x1 = -this.x
	const y1 = -this.y;
	const x2 = (-p5.width/2 + p5.mouseX) / this.zoomValue - this.x;
	const y2 = (-p5.height/2 + p5.mouseY) / this.zoomValue - this.y;
	const dist = Math.round(p5.dist(x1, y1, x2, y2) * this.zoomValue);
	const angle = Math.atan2(y2 - y1, x2 - x1);
	const distX = Math.round(Math.cos(angle) * dist);
	if (Math.abs(distX) > p5.width / 2 - 100) {
	this.x += Math.sign(distX) * config.cameraSpeed;
	}
	const distY = Math.round(Math.sin(angle) * dist);
	if (Math.abs(distY) > p5.height / 2 - 100) {
	this.y += Math.sign(distY) * config.cameraSpeed;
	}
	}

It seems that p5.js is no longer used except in the case above but even then it just throws errors to the console.

Can references to p5.js be fully removed from the source code?

Add support for scenario 11

Unable to move heroes after browser window is resized

1. Start a one-player game.
2. Move some heroes around, this should work.
3. Now resize your browser's window a few times.
4. Try moving some heroes around again, this will now stop working.
5. Open the debugger panel of the browser and you should see an error.

Production:

Uncaught TypeError: Cannot read property 'nodeName' of null
    at Object.mouseMove (bundle.js:1)
    at e (bundle.js:1)

Local Development:

events.js:262 Uncaught TypeError: Cannot read property 'nodeName' of null
    at Object.mouseMove (events.js:262)
    at draw (user.js:90)

Add support for scenario 9

• allow a specific spectator the ability to alert other players
• the alert button should not be displayed for regular players

Heroku application has crashed

Looks like the game is currently down.

Web Socket Connections broken

To me it seems, the web socket connection is broken since updating to socket.io ^2.4.0. No tiles appear, games do not appear to others, cannot be started and the browser's developer tools show a status code 400.

Though changing the socket.io version back down to ~2.2.0 or upgrading to ^2.4.1 fixes that problem.

Include a link back to GitHub on the main page

There should be a link back to GitHub so players know where to go to report feature requests and bugs.

Restrict user actions to what they have been assigned

Currently, all players can do all the actions which does not match the board game's rules. Users should only be able to perform the action that they have been assigned.

Add Multiplayer

Hey would be nice if you could add a multiplayer option to play with friends. Maybe with an invitation code?
Connection could be implemented via Websockets.

Repository has no license

This repository currently has no license associated with it. The lack of a license creates ambiguity as to what people can or cannot do with the code. I suggest choosing a license as soon as possible to rectify this.