Giter Site home page Giter Site logo

use pygit2's blame support about git-deps HOT 6 CLOSED

aspiers avatar aspiers commented on July 28, 2024
use pygit2's blame support

from git-deps.

Comments (6)

wetneb avatar wetneb commented on July 28, 2024 2

According to my experiments the slowdown is due to libgit2 itself: libgit2/libgit2#3027.
Looking at their repository it seems that their implementation of blame is not very ripe (for instance libgit2/libgit2#6572 fixes a correctness issue and has been open for months) and is apparently unmaintained as the contributor who contributed blame support is not active there anymore.

So it's probably better to stick to the current solution.

from git-deps.

wetneb avatar wetneb commented on July 28, 2024

I had a go at this but it seems that migrating to pygit2's blame actually slows things down. It's unclear to me what's going on under the hood (I'd need to be able to debug libgit2 itself).

from git-deps.

aspiers avatar aspiers commented on July 28, 2024

That's strange, but thanks a lot for trying! Maybe ask the pygit2 or libgit2 community for advice?

from git-deps.

aspiers avatar aspiers commented on July 28, 2024

Well thanks a lot for trying anyway! I guess we just need to watch this space...

from git-deps.

RonnyPfannschmidt avatar RonnyPfannschmidt commented on July 28, 2024

If the new impl works, would it be sensible to leave it behind a gruesomely named opt in, so a test could track when upstream libgit is doing better?

from git-deps.

aspiers avatar aspiers commented on July 28, 2024

Makes sense!

from git-deps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.