Comments (7)
@jmloeffler Indicated he will pick this one up
from aspnet.security.oauth.providers.
Yep, I am working on it. I've got it working already but want to spend a little more time testing and ran out of hours in the day.
from aspnet.security.oauth.providers.
No problem. I just tagged you to make sure no-one else picks it up.
Take your time with getting it done :)
from aspnet.security.oauth.providers.
I've noticed that we've got values in the providers for the clientid and secret in the Startup.cs of the sample app. Are those legit values? I would normally leave these blank and comment out the section so the provider isn't active until someone provides values.
from aspnet.security.oauth.providers.
They were legit at the time of merging the PR so that @PinpointTownes could easily test, since he did not have to go and create an app just to test. I deleted mine in the meantime, and you should do the same.
But it is not a very good practice to leave those in. We should come up with something else. The important thing is that @PinpointTownes must be easily able to test PRs
from aspnet.security.oauth.providers.
@jerriep I totally agree 👍
FYI: I already removed all the app.Use*Authentication
calls (except GitHub/Twitter/Google) from the MVC sample since they were no longer working.
from aspnet.security.oauth.providers.
Merged, thanks! 1836930
from aspnet.security.oauth.providers.
Related Issues (20)
- MyGet.org is down HOT 6
- Update AspNet.Security.OAuth.LinkedIn to work with Sign In with LinkedIn using OpenID Connect HOT 2
- Weixin use qrcode login HOT 2
- Unable to retrieve OpenID configuration for Apple HOT 11
- how to implement external login provders(linkedin) login using .net core with openidconnect? HOT 1
- Twitter v2: The oauth state was missing or invalid. HOT 6
- X/Twitter v2 iPhone Browser Interception Issue: Correlation failed. HOT 7
- Cannot register all BattleNet Provider Regions at the same time. HOT 5
- Okta Provider not respecting Options settings HOT 3
- Multiple tenants for Okta at runtime HOT 3
- Unable to obtain authorization during callback after logging in using QQ HOT 3
- Angular client HOT 2
- I could not authenticate by Linkedin when I redirected to redirect_url after confirm linkedin page authentication HOT 2
- Add Atlassian Provider
- How do I update Claims (Discord provider)? HOT 1
- Where to place logic adding additional claims obtained via an alternate REST endpoint HOT 1
- Sign in with Apple returns 'invalid_client' error for the first try HOT 4
- LinkedIn Authentication Fails HOT 2
- QuickBooks. Doesn't contain Sandbox settings. HOT 3
- Neither first name nor last name populated in claims principle by Apple provider HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspnet.security.oauth.providers.