Giter Site home page Giter Site logo

Comments (7)

jerriep avatar jerriep commented on August 19, 2024

@jmloeffler Indicated he will pick this one up

from aspnet.security.oauth.providers.

jmloeffler avatar jmloeffler commented on August 19, 2024

Yep, I am working on it. I've got it working already but want to spend a little more time testing and ran out of hours in the day.

from aspnet.security.oauth.providers.

jerriep avatar jerriep commented on August 19, 2024

No problem. I just tagged you to make sure no-one else picks it up.

Take your time with getting it done :)

from aspnet.security.oauth.providers.

jmloeffler avatar jmloeffler commented on August 19, 2024

I've noticed that we've got values in the providers for the clientid and secret in the Startup.cs of the sample app. Are those legit values? I would normally leave these blank and comment out the section so the provider isn't active until someone provides values.

from aspnet.security.oauth.providers.

jerriep avatar jerriep commented on August 19, 2024

They were legit at the time of merging the PR so that @PinpointTownes could easily test, since he did not have to go and create an app just to test. I deleted mine in the meantime, and you should do the same.

But it is not a very good practice to leave those in. We should come up with something else. The important thing is that @PinpointTownes must be easily able to test PRs

from aspnet.security.oauth.providers.

kevinchalet avatar kevinchalet commented on August 19, 2024

@jerriep I totally agree 👍

FYI: I already removed all the app.Use*Authentication calls (except GitHub/Twitter/Google) from the MVC sample since they were no longer working.

from aspnet.security.oauth.providers.

kevinchalet avatar kevinchalet commented on August 19, 2024

Merged, thanks! 1836930

from aspnet.security.oauth.providers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.