Giter Site home page Giter Site logo

Comments (3)

kevinchalet avatar kevinchalet commented on August 19, 2024

Reacting to these naming changes is on my todo list 👍

That said, I won't align our providers with the new names used by the ASP.NET team for at least 2 reasons:

  • This new naming pattern is inconsistent in ASP.NET 5 itself: the OAuth2/OIDC providers have been renamed but the cookies middleware is still named CookieAuthenticationMiddleware to avoid type collisions (with the CookieOptions in aspnet/HttpAbstractions).
  • The risk of having a type collision is too high with these new names: [Provider]Options or [Provider]Extensions are generic enough to result in weird things if you use a custom client to retrieve data from the provider in Startup.cs. I don't want to take this risk.

from aspnet.security.oauth.providers.

jerriep avatar jerriep commented on August 19, 2024

Yeah, I agree on the risk on name collision being high

from aspnet.security.oauth.providers.

kevinchalet avatar kevinchalet commented on August 19, 2024

Fixed: 3f58f98

@jerriep I also fixed the Yeoman generator. Feel free to push a new update when you can 👍

from aspnet.security.oauth.providers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.