Comments (4)
Hey 😄
Try removing these two things, which are already added by ASP.NET Identity when you call services.AddIdentity()
/app.UseIdentity()
(with different schemes, which probably explains why Identity cannot see the identity produced by your own cookie/GitHub middleware):
services.Configure<SharedAuthenticationOptions>(options => {
options.SignInScheme = CookieAuthenticationDefaults.AuthenticationScheme;
});
app.UseCookieAuthentication(options => {
options.AutomaticAuthentication = true;
options.AuthenticationScheme = CookieAuthenticationDefaults.AuthenticationScheme;
options.LoginPath = new PathString("/account/login");
});
from aspnet.security.oauth.providers.
@PinpointTownes, thanks a lot for this great answer. Indeed, adding app.UseCookieAuthentication
confuses identity because of the two different schemes. The problem is now solved.
Now, for the scenario where the user is not present in the database, Identity will redirect us to the ExternalLoginConfirmation
view, which will ask for the email address if not present in the claims.
I think that we should add to the GitHub middleware the ability of adding an the email claim in the case where the developer adds the user:email
scope.
var email = GitHubHelper.GetEmail(payload);
if (!string.IsNullOrEmpty(email))
{
identity.AddClaim(new Claim(ClaimTypes.Email, email, ClaimValueTypes.String, Options.ClaimsIssuer));
}
I have another question regarding the addition of the claims to the ClaimsIdentity
, why are you using AddOptionalClaim
instead of simply AddClaim
?
I'll probably submit a PR (though I have to read the contribution guide before 😄 ) by the end of the day regrading the improvement above.
from aspnet.security.oauth.providers.
I think that we should add to the GitHub middleware the ability of adding an the email claim in the case where the developer adds the user:email scope.
Good idea! Feel free to submit a PR to fix that 👍
I have another question regarding the addition of the claims to the ClaimsIdentity, why are you using AddOptionalClaim instead of simply AddClaim ?
For readability: AddOptionalClaim
internally does exactly what your snippet does, but allows chained calls.
from aspnet.security.oauth.providers.
I think that we should add to the GitHub middleware the ability of adding an the email claim in the case where the developer adds the user:email scope.
Done: 23b52e6
from aspnet.security.oauth.providers.
Related Issues (20)
- MyGet.org is down HOT 6
- Update AspNet.Security.OAuth.LinkedIn to work with Sign In with LinkedIn using OpenID Connect HOT 2
- Weixin use qrcode login HOT 2
- Unable to retrieve OpenID configuration for Apple HOT 11
- how to implement external login provders(linkedin) login using .net core with openidconnect? HOT 1
- Twitter v2: The oauth state was missing or invalid. HOT 6
- X/Twitter v2 iPhone Browser Interception Issue: Correlation failed. HOT 7
- Cannot register all BattleNet Provider Regions at the same time. HOT 5
- Okta Provider not respecting Options settings HOT 3
- Multiple tenants for Okta at runtime HOT 3
- Unable to obtain authorization during callback after logging in using QQ HOT 3
- Angular client HOT 2
- I could not authenticate by Linkedin when I redirected to redirect_url after confirm linkedin page authentication HOT 2
- Add Atlassian Provider
- How do I update Claims (Discord provider)? HOT 1
- Where to place logic adding additional claims obtained via an alternate REST endpoint HOT 1
- Sign in with Apple returns 'invalid_client' error for the first try HOT 4
- LinkedIn Authentication Fails HOT 2
- QuickBooks. Doesn't contain Sandbox settings. HOT 3
- Neither first name nor last name populated in claims principle by Apple provider HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspnet.security.oauth.providers.