Giter Site home page Giter Site logo

Comments (9)

haythem avatar haythem commented on August 19, 2024

Can you please go side by side with Asp.Net packages versions ? I know that the project is WIP but setting the same version is more semantic.

from aspnet.security.oauth.providers.

kevinchalet avatar kevinchalet commented on August 19, 2024

AFAICT, this problem only impacts the GitHub middleware, which is the only one using System.Dynamic.Runtime. Sadly, NuGet.org doesn't allow removing a package to republish it, so downloading the right dependency yourself is currently the only option:

https://www.myget.org/F/aspnetvnext/api/v2/package/System.Dynamic.Runtime/4.0.11-rc2-23519

from aspnet.security.oauth.providers.

kevinchalet avatar kevinchalet commented on August 19, 2024

Can you please go side by side with Asp.Net packages versions ? I know that the project is WIP but setting the same version is more semantic.

Heh no, it has nothing to do with semantic, just with convenience 😄

I agree it would make your life easier, but it would tie our development timeline to ASP.NET 5's roadmap, which is definitely not what we want (the CLR team shares the same concerns, and so do the Glimpse authors: https://www.nuget.org/packages/Glimpse/2.0.0-beta1)

from aspnet.security.oauth.providers.

haythem avatar haythem commented on August 19, 2024

Thanks for your blazing fast support. I'll add the dependency manually through the project.json file. I'll keep you posted.

from aspnet.security.oauth.providers.

kevinchalet avatar kevinchalet commented on August 19, 2024

FYI, I sent a ticket to the NuGet gallery team to remove the buggy package. I hope they will consider it serious enough to accept it.

from aspnet.security.oauth.providers.

kevinchalet avatar kevinchalet commented on August 19, 2024

The NuGet gallery team refused to remove the buggy package. We'll have to push a new version to fix that.

from aspnet.security.oauth.providers.

jerriep avatar jerriep commented on August 19, 2024

@PinpointTownes Did they explain their reasoning for not allowing removal of packages?

from aspnet.security.oauth.providers.

somewhatabstract avatar somewhatabstract commented on August 19, 2024

@PinpointTownes That version of System.Dynamic.Runtime isn't even available anymore.

from aspnet.security.oauth.providers.

kevinchalet avatar kevinchalet commented on August 19, 2024

@PinpointTownes Did they explain their reasoning for not allowing removal of packages?

They pretended it would have broken people (which was wrong, as the package couldn't be used correctly, anyway).

The alpha4 package (for RC2) won't be affected, because I pinned the right version when building the packages this time: https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/blob/master/src/AspNet.Security.OAuth.GitHub/project.json#L45 😄

from aspnet.security.oauth.providers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.