DualWriter seems to have concurrency issues

[aspnet]

DualWriter seems to have concurrency issues

[Tratcher]

This seems to be an issue with Console.Out and Console.Error when they are pointed to the same destination. It does not appear to be related to DualWriter.
https://github.com/aspnet/AspNetKatana/blob/dev/src/Microsoft.Owin.Hosting/Tracing/TraceOutputFactory.cs#L22
https://stackoverflow.com/a/38746852/2588374

[ZigMeowNyan]

I know in my case I'm not explicitly setting the output or error streams. I've checked my logging library (NLog), but a quick repository search doesn't show it redirecting the output or error streams (e.g. Console.SetOut or Console.SetError), either, outside of its tests. I'll review the other libraries as well, later. It's not impossible, but I'm not really anticipating the Nuget packages I'm using to be hooking themselves into the Console out/err streams. As I understand it the System.Diagnostics.Trace doesn't directly log to the console, either, except when added as in the line you've mentioned.

I'll see if I can inspect those streams and find more information about them.

[alexander-williamson]

Nice writeup @ZigMeowNyan! I agree that calls to Trace.WriteLine shouldn't throw exceptions.

This bug caught me today an Owin app with Uncaught Exceptions being handled by us, eventually posting through to NewRelic which just writes to Trace under the hood without any magic.

I see this is included in Discussions. Is there a timeline to that?

[t1seungy]

We have similar deadlock issue from the DualWriter after upgrading nuget packages of OWIN host to v4.0.0.0. It crashes the OWIN host. Any update for this issue? Thank you for your prompt help and support.

Here is the Nuget packages:

Microsoft.AspNet.WebApi.Owin @ v5.2.4
Microsoft.AspNet.WebApi.OwinSelfHost @ v5.2.4
Microsoft.Owin @ v4.0.0.0
Microsoft.Owin.Host.HttpListener @ v4.0.0.0
Microsoft.Owin.Hosting @ v4.0.0
Owin @ v1.0.0

Here is the Exception:

System.ArgumentOutOfRangeException: Count cannot be less than zero.
Parameter name: count
at System.String.CopyTo(Int32 sourceIndex, Char[] destination, Int32 destinationIndex, Int32 count)
at System.IO.StreamWriter.Write(String value)
at System.IO.TextWriter.SyncTextWriter.Write(String value)
at Microsoft.Owin.Hosting.Tracing.DualWriter.Write(String value)
at System.Diagnostics.TextWriterTraceListener.Write(String message)
at System.Diagnostics.TraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
at System.Diagnostics.TraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
at System.Diagnostics.TraceInternal.TraceEvent(TraceEventType eventType, Int32 id, String format, Object[] args)
at System.Web.Http.Tracing.SystemDiagnosticsTraceWriter.TraceMessage(TraceLevel level, String message)
at System.Web.Http.Tracing.SystemDiagnosticsTraceWriter.Trace(HttpRequestMessage request, String category, TraceLevel level, Action1 traceAction) at System.Web.Http.Tracing.ITraceWriterExtensions.TraceBeginEndAsync[TResult](ITraceWriter traceWriter, HttpRequestMessage request, String category, TraceLevel level, String operatorName, String operationName, Action1 beginTrace, Func1 execute, Action2 endTrace, Action`1 errorTrace)
at System.Web.Http.Tracing.Tracers.RequestMessageHandlerTracer.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.DelegatingHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Web.Http.HttpServer.d__24.MoveNext()

[analogrelay]

Another report of this issue here SignalR/SignalR#4146, which does not appear to be running under the debugger.