Discussion: Library destination root

[aspnet]

Discussion: Library destination root

[acinep]

I like defaultDestination, and the use of the library name if nothing else is provided. This is pretty much what we used to have with PackMan and worked great.

[justcla]

Thanks for the input @acinep .

But should defaultDestination be used as a prefix to the destination of the library (whether provided explicitly or defaulted to the library name)?

{
  "version": "1.0",
  "defaultProvider": "cdnjs",
  "defaultDestination": "/wwwroot/lib",
  "libraries": [
    {
      "library": "[email protected]",
    },
    {
      "library": "[email protected]",
      "destination": "otherlibs",
    },
    {
      "library": "[email protected]",
      "destination": "/foobar",
    }
  ]
}

Question 1:
In the example above, which folder would the "barlib" files go to?
a - "/otherlibs" (current behavior)
b - "/wwwroot/lib/otherlibs" (defaultDestination prefixed to explicitly set relative destination)

(separately)
Question 2:
Which folder would the "foolib" files go to?
a - "/wwwroot/lib" (current behavior)
b - "/foolib" (default to library name)
c - "/wwwroot/lib/foolib" (defaultDestination prefixed to default library name)

Question 3:
Which folder would the "foobar" files go to? (Note the destination start with "/")
a - "/foobar" (current behavior)
b - "/wwwroot/bin/foobar" (defaultDestination prefixed to explicitly set root path)

[justcla]

Or should we introduce a new property for the destination prefix?

[mattfraley1]

If defaultDestination is prefixed in both cases, question 1 & 2 above, then you wouldn't be able to dump a file directly lib folder such as /wwwroot/lib/coollib.js. I suppose you could specify destination as /wwwroot/lib.

I guess developers either want their libraries in library subfolders or they don't. Maybe a property could be added such as "useLibraryFolders"? Then you could set it to the true or false and get the behavior you like best.

[justcla]

Thanks @mattfraley1.
Yes, the design is that a forward slash ("/") at the beginning of the destination would indicate that the destination is relative to the root of the project.
ie. "/scripts" would send files to the [root]/scripts, but
"scripts" would send files to [defaultDestinationFolder]/scripts.'

Thanks for the suggestion about "useLibraryFolders". We will consider that!

[lgoudriaan]

@justcla I expected it to work like this, but unfortunately, it's not implemented yet.

Question 1: B
Question 2: A
Question 3: A

The useLibraryFolders would be nice, you should be able to override this behavior by setting the destination in the library setting.

Example:

{
  "version": "1.0",
  "defaultProvider": "unpkg",
  "defaultDestination": "Assets/Libraries/",
  "useLibraryFolders": true,
  "libraries": [
    {
      "library": "[email protected]",
      "destination": "jquery-custom" // Assets/Libraries/jquery-custom/ (custom library folder)
    },
    {
      "library": "[email protected]"  // Assets/Libraries/bootstrap/
    },
    {
      "library": "[email protected]",
      "destination": "" // Assets/Libraries/coollib.js (overrides useLibraryFolders)
    },
    {
      "library": "[email protected]",
      "destination": "/foobar" // foobar (overrides root defaultDestination)
    }
  ]
}

This will give you full flexibility.