Giter Site home page Giter Site logo

Comments (3)

twillouer avatar twillouer commented on July 20, 2024

Nothing can extend String :P

from assertj.

joel-costigliola avatar joel-costigliola commented on July 20, 2024

Yep, that's right :) but the second line compiles without problems.
Anyway, the main point here is to show that the last 3 assertThat don't compile.

from assertj.

joel-costigliola avatar joel-costigliola commented on July 20, 2024

William, your solution works but it still relies on generics which is root of the problem.
Sorry, the issue was not clear, let's take another example with an Employee class inheriting from Person to show where is the problem :

Employee bill = new Employee("Bill", 50, "micro$oft");
assertThat(bill).isEqualTo(bill); // OK
// now let's view billou as a Person and not an Employee anymore
Person billou = bill;
// next line leads to a compile error although bill and billou are exactly the same.
assertThat(bill).isEqualTo(billou); 

The idea here is simply to use an Object instead of generic parameter A in AbstractAssert.
I know we loose type checking here but I'm not sure if it was really useful (please tell me if you disagree).

This issue is just a step toward less generics and will be followed by others to remove generics in assertions methods parameter like contains (but one step at a time)

Note that AbstractAssert generic parameter must be kept for assertions based on Condition.

Thanks for the effort though !

from assertj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.