ComparingOnlyFieldsOfType only provided types for comparison

[timmisset]

ComparingOnlyFieldsOfType only provided types for comparison

[joel-costigliola]

This is a bug, we don't register the fields of types that don't match the compared types when these types could have fields whose type are in the compared types list.

[joel-costigliola]

Thanks for reporting this, we'll look into it shortly !

[timmisset]

As requested by @joel-costigliola

using version 3.24.2 the following assertion fails. Using 3.25.0-SNAPSHOT the assertion succeeds.

        BuildRecipe buildRecipe = TestBuildRecipeBuilder.getBuildRecipe();
        buildRecipe.getBuildItems().get(0).setBuildItemId("buildItemId");
        buildRecipe.getBuildItems().get(0).getBuildItemChildren().get(0).setBuildItemChildId("buildItemChildId");

        BuildRecipe buildRecipe2 = TestBuildRecipeBuilder.getBuildRecipe();
        buildRecipe2.getBuildItems().get(0).setBuildItemId("buildItemId");
        buildRecipe2.getBuildItems().get(0).getBuildItemChildren().get(0).setBuildItemChildId(null);

        // basic recursive comparison
        assertThat(buildRecipe2).usingRecursiveComparison().isNotEqualTo(buildRecipe);

        // compare only the types with the differences. This doesn't work in 3.24.2 but does work in 3.25.0
        assertThat(buildRecipe2).usingRecursiveComparison()
                .comparingOnlyFieldsOfTypes(AbstractBuildItem.class, BuildItemChild.class)
                .isNotEqualTo(buildRecipe);

        // compare ignoring the types with the differences. This works in both versions
        assertThat(buildRecipe2).usingRecursiveComparison()
                .ignoringFieldsOfTypes(AbstractBuildItem.class, BuildItemChild.class)
                .isEqualTo(buildRecipe);

Very nice!

I did notice one additional difference. The field name for 'setBuildItemId' is 'buildItemId' so I checked what would happen if I specified comparing only that fieldname:

        BuildRecipe buildRecipe = TestBuildRecipeBuilder.getBuildRecipe();
        buildRecipe.getBuildItems().get(0).setBuildItemId("buildItemId");
        buildRecipe.getBuildItems().get(0).getBuildItemChildren().get(0).setBuildItemChildId("buildItemChildId");

        BuildRecipe buildRecipe2 = TestBuildRecipeBuilder.getBuildRecipe();
        buildRecipe2.getBuildItems().get(0).setBuildItemId("buildItemId");
        buildRecipe2.getBuildItems().get(0).getBuildItemChildren().get(0).setBuildItemChildId(null);

        // basic recursive comparison
        assertThat(buildRecipe2).usingRecursiveComparison().isNotEqualTo(buildRecipe);

        // compare only the fields with the differences.
        // in 3.24.0 - Assertion error, objects are considered equal
        // in 3.25.0 - IllegalArgumentException "The following fields don't exist: {buildItemChildId}{buildItemId}"
        assertThat(buildRecipe2).usingRecursiveComparison()
                .comparingOnlyFields("buildItemId", "buildItemChildId")
                .isNotEqualTo(buildRecipe);

        // compare ignoring the fields with the differences, this results in the same assertion error for both 3.24.2 and 3.25.0-SNAPSHOT
        // in 3.24.2 - Assertion error:
        // field/property 'buildItems[0].buildItemChildren[0].buildItemChildId' differ:
        // - actual value  : null
        // - expected value: "buildItemChildId"
        // in 3.25.0 - Assertion error, same as in 3.24.0
        assertThat(buildRecipe2).usingRecursiveComparison()
                .ignoringFields("buildItemId", "buildItemChildId")
                .isEqualTo(buildRecipe);