Giter Site home page Giter Site logo

Comments (4)

Uzaaft avatar Uzaaft commented on May 29, 2024 1

@ksnll I've attempted to add the functionality in #231.
@mehalter I'm not sure about the pattern we want to have. Should it be:

if prettier:
	disable_eslint() 
if eslint:
	disable_prettier()
if both:
	keep_both()
if none:
	keep_both()

from astrocommunity.

Uzaaft avatar Uzaaft commented on May 29, 2024

I'm not sure of we should begin to parse the package.json files to see if the eslintConfig or prettier keys are present. Any thoughts @owittek ?

from astrocommunity.

owittek avatar owittek commented on May 29, 2024

We'd have to check for performance implications but wouldn't just removing the first check for the package.json be sufficient?

from astrocommunity.

ksnll avatar ksnll commented on May 29, 2024

Some people might have eslint & prettier configured in their package.json, so if we remove the check altogether it would not load for them.
I still think it would be better than the current situation tho, as it would be an easy fix to have prettier/eslint working again (ust create an empty prettierrc/eslintrc), while the current issue is not as easily solvable

from astrocommunity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.