Comments (5)
Hi @simojo, I see that you are assigned to this issue. Can you please give us a status update? Is this a feature that you might be able to implement and have ready by the end of the next sprint?
If you are going to work on this feature, I encourage you to check-in with the senior software engineer on our team who can advise you on where to integrate your code. You should also chat with our QA engineer because we need to ensure that your code has high test coverage and that we can have a suitable confidence in its correctness.
Finally, if you could implement this feature then we should definitely talk about integrating it into other tools like gatorgrade
. It would be really helpful to have a remote-download feature for configuration files!
from chasten.
@gkapfham I am currently still working on this, mostly because I haven't devoted time to it yet. Currently trying to test URL validation and writing a test case accordingly. Hypothesis has a fuzzing strategy where you can include randomly generated URLs, but this appears to be a test feature, so it could be potentially volatile to include in our tool. https://hypothesis.readthedocs.io/en/latest/data.html#hypothesis.provisional.urls
What do we think of using Hypothesis's provisional URL strategy in a unit test?
from chasten.
@gkapfham I have an additional question for you regarding how chasten reads configuration files. This is not obvious to me, so I figured it was appropriate to ask you: If we were to attempt to pull a remote configuration by including https://raw.githubusercontent.com/AstuteSource/chasten-configuration/master/config.yml as the input config file, I'm now seeing that every config.yml
is going to reference local files. Do you have any recommended strategies for inputting remote configuration files? Should we allow the specification of checks
in the main config.yml
file? I'm having a hard time deciding what design choices here would be appropriate, because it seems that I'm going to have to modify an existing feature.
from chasten.
I have decided that the above comment no longer needs to be addressed. The design I am implementing now will allow the following rules:
--config
may beUnion[Path, URL]
(URL
provided bypurl
library)- If
config.yml
is aPath
, thechecks-files
yaml values may either bePath
orURL
objects. - If
config.yml
is aURL
, thechecks-files
yaml values may be onlyURL
objects.
Does anyone else have any opinions on this?
from chasten.
Hello @simojo, yes, what you have described sounds like a very good idea! Thanks for pushing forward this issue, I think that it will be a great contribution to the tool.
from chasten.
Related Issues (20)
- Create a Containerized Dev Environment HOT 5
- Document Pain Points & Solutions Regarding Dev Environments HOT 7
- Error while running chasten after fresh install HOT 1
- Provide a `--help` command when calling `chasten` alone HOT 6
- Installing Chasten for MacOS HOT 5
- Issue running the tests (pytest) HOT 2
- Attemp to resolve Chasten installation issue by removing pysqlite3 HOT 6
- No such Column as filelines error when running integrate HOT 2
- Issue finding executable for datasette on Windows HOT 2
- Use `Path` infix operator `/` in unit tests HOT 1
- Test case that uses source code of `chasten` fails in development branch HOT 3
- Github Actions needs to check more then just Linux
- Encoding Error when saving analyzed data to JSON
- Interact Command crashes when clicking out of Analyze section HOT 2
- Automate Version Updates For PyPi HOT 6
- Coverage badge action not authorized to pull from secret gist HOT 2
- Coverage Badge a Grey Percentage
- Remove covbadge from CI HOT 1
- PIP will not install/upgrade on the Windows OS build HOT 1
- Add total check count to `analyze` output
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chasten.