Giter Site home page Giter Site logo

Comments (5)

gkapfham avatar gkapfham commented on September 4, 2024

Hi @simojo, I see that you are assigned to this issue. Can you please give us a status update? Is this a feature that you might be able to implement and have ready by the end of the next sprint?

If you are going to work on this feature, I encourage you to check-in with the senior software engineer on our team who can advise you on where to integrate your code. You should also chat with our QA engineer because we need to ensure that your code has high test coverage and that we can have a suitable confidence in its correctness.

Finally, if you could implement this feature then we should definitely talk about integrating it into other tools like gatorgrade. It would be really helpful to have a remote-download feature for configuration files!

from chasten.

simojo avatar simojo commented on September 4, 2024

@gkapfham I am currently still working on this, mostly because I haven't devoted time to it yet. Currently trying to test URL validation and writing a test case accordingly. Hypothesis has a fuzzing strategy where you can include randomly generated URLs, but this appears to be a test feature, so it could be potentially volatile to include in our tool. https://hypothesis.readthedocs.io/en/latest/data.html#hypothesis.provisional.urls

What do we think of using Hypothesis's provisional URL strategy in a unit test?

from chasten.

simojo avatar simojo commented on September 4, 2024

@gkapfham I have an additional question for you regarding how chasten reads configuration files. This is not obvious to me, so I figured it was appropriate to ask you: If we were to attempt to pull a remote configuration by including https://raw.githubusercontent.com/AstuteSource/chasten-configuration/master/config.yml as the input config file, I'm now seeing that every config.yml is going to reference local files. Do you have any recommended strategies for inputting remote configuration files? Should we allow the specification of checks in the main config.yml file? I'm having a hard time deciding what design choices here would be appropriate, because it seems that I'm going to have to modify an existing feature.

from chasten.

simojo avatar simojo commented on September 4, 2024

I have decided that the above comment no longer needs to be addressed. The design I am implementing now will allow the following rules:

  • --config may be Union[Path, URL] (URL provided by purl library)
  • If config.yml is a Path, the checks-files yaml values may either be Path or URL objects.
  • If config.yml is a URL, the checks-files yaml values may be only URL objects.

Does anyone else have any opinions on this?

from chasten.

gkapfham avatar gkapfham commented on September 4, 2024

Hello @simojo, yes, what you have described sounds like a very good idea! Thanks for pushing forward this issue, I think that it will be a great contribution to the tool.

from chasten.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.