Consistent Hang With `search-auto-complete t`

[brosasaki]

Consistent Hang With `search-auto-complete t`

[brosasaki]

EDIT: I’ve found that setting search-auto-complete-p nil in the context-buffer configuration is a work-around for the issue, for now.

[aadcg]

@brosasaki thanks for reporting.

It seems that after 36589e3, 8b00a2f and 14dac1e we still got it wrong. @shamazmazum, @jmercouris can you reproduce the reported issue?

It may be that the feature was poorly designed from its inception (from 8887a7e) and we're trying to fix a house made of sand.

We should probably do it from scratch and set search-auto-complete-p to nil by default in the mean time.

[jmercouris]

Maybe. I'll have to look. In the interim, I'm more than happy to default to nil for this option.

[shamazmazum]

@aadcg I do not have this issue because I run nyxt with

(define-configuration context-buffer
  ((search-always-auto-complete-p nil)))

in the config :) I'll test it without this setting later. Not sure if search-auto-complete-p is the same as search-always-auto-complete-p.

[shamazmazum]

I cannot reproduce it. Navigation seems to be working fine and nyxt does not hang up.

[aadcg]

@shamazmazum did you test against the master branch or the 3.11.6 tag? Note that your PR #3385 will be part the next release. Regardless, it shouldn't make any difference since, if I recall correctly, the changes are orthogonal to the issue at hand.

I can't reproduce it as well. We should resort to the suggestion above if the issue is reproducible.

[shamazmazum]

@aadcg I tested against 3.11.6, but with those changes cherry-picked.

[aadcg]

Although not reproducible, let's keep this piece of information in the back of our heads.

Should anyone experience hangs, they could follow the tip and set search-auto-complete to nil.