Giter Site home page Giter Site logo

Invalid Git submodule about nyxt HOT 2 CLOSED

oblivikun avatar oblivikun commented on September 22, 2024
Invalid Git submodule

from nyxt.

Comments (2)

aadcg avatar aadcg commented on September 22, 2024

@oblivikun thanks for reporting.

The library is now hosted elsewhere. Fixed via 832174d.

from nyxt.

aadcg avatar aadcg commented on September 22, 2024

This is not yet fixed because some dependencies (such as nfiles) also depend on the library and register it as a git submodule. AFAIK, there's no way to run git clone --recurse-submodules ... exclusively on direct submodules.

While we could fix the URL everywhere, there is no good reason for these CL libraries (maintained by @atlas-engineer/atlas) to register their dependencies as git submodules. It enables running CI routines in their own repositories, which isn't wise from a maintenance perspective since that env must be kept with sync with that of Nyxt. It would wiser to run the test suite of those libraries within Nyxt's CI.

I'll take this opportunity to fix the long standing issue mentioned above.

from nyxt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.