Switch to prebuildify & node-gyp-build

[TylerLeonhardt]

Switch to prebuildify & node-gyp-build

[sergiou87]

Hey @TylerLeonhardt !

Thank you for your suggestion, I didn't know about the existence of prebuildify. Looking at the prebuild-install link you provided, it mentions this downside:

The installed npm package is larger on disk. Using Node-API alleviates this because Node-API binaries are runtime-agnostic and forward-compatible.

If I understand this correctly, you get rid of the 759KB from prebuild-install… but will get new binaries of keytar that you might or might not need. Looking at the latest release of keytar we're talking about ~800KB that outweigh the 759KB from prebuild-install.

Is that correct? Or will your bundler get rid of the binaries that aren't needed? 🤔

In case my reasoning is wrong and this change is actually worth doing, we can't promise any ETA 😢 Right now keytar is being maintained by the GitHub Desktop team, which is quite small. We definitely accept contributions to the repository, but one idea I discussed with one of your teammates a few months ago was transferring ownership of keytar to the VS Code team, since it was kind of a core dependency to you.

[thegecko]

Also see benefits as outlined by @vweevers in #255 (comment)