Comments (4)
isotope-ui relies on the syntax-variables to set the @syntax-background-color
. This creates a problem if the syntax-variables file contains variable names that are also used in the ui theme. Because my theme started as a copy of the One theme, that tends to happen :). In this case I'm also using a @theme-color
variable and that creates a recursion.
So, I can (and will in a moment) fix it on my end.
However, we may need a rule that syntax-variables and ui-variables files stick to the required values, to make them safe for importing. These files being the "API" to pass style across packages might require some strictness here. Anything else should perhaps be moved to a different file.
from one-dark-syntax.
@braver I think you can keep it as is and it should be fixed in One. Isotope works for all other themes I tested. It's just that I set it up like this:
// colors.less
@syntax-contrast: ...;
@syntax-base-color: ...;
// syntax-variables.less
@import "colors";
@syntax-background-color: darken(@syntax-base-color, @syntax-contrast);
Now when Isotope UI tries to use the syntax-variables.less
there is an error because the variables from colors.less
are missing.
So as a convention we could say that syntax-variables.less
shouldn't rely on other files. That way other themes/packages can import it without breaking.
from one-dark-syntax.
I renamed @theme-color
and Isotope now also works with One-syntax, so that made the problem go away for my theme. I still think that introducing undocumented variables in syntax-variables (or ui-variables for that matter) might cause problems for packages as well.
from one-dark-syntax.
You're right.. the conflict was @theme-color
. I thought that it would just get overridden if you import it.
Ok, closing this for now. But yeah.. we'll have to look into it once the theme settings get added.
from one-dark-syntax.
Related Issues (20)
- PHP highlighting messed up in Atom Beta (1.21.0) HOT 8
- Wrong curly bracket color HOT 5
- Make background pure black, and/or add config option for background color HOT 1
- Code background color is not same with background color HOT 2
- Comments move text below HOT 6
- Syntax highlight issue HOT 4
- "DISTINCT" in SQL is not highlighted HOT 2
- improve json highlighting HOT 4
- and, or, ... keywords not highlighted HOT 1
- 1.6.0 breaks syntax highlighting on one light/dark HOT 4
- Syntax highlight broken after update HOT 10
- Latest Atom Breaks One Dark Syntax HOT 2
- Markdown Syntax coloring (links vs. emphasis) HOT 1
- Question about custom syntax HOT 3
- <unknown> is deprecated. HOT 1
- PHP syntax highlighting issue inside HTML quotes HOT 1
- Improve LESS Highlighting
- Syntax color is mismatch for this PHP source (1.18.0) HOT 1
- How to remove italics from comments HOT 1
- Comment documentation highlighting is incorrect for class properties. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from one-dark-syntax.