Replacing multiple characters with newlines in a scanInRange only replaces the first occurence

[jazzpi]

Replacing multiple characters with newlines in a scanInRange only replaces the first occurence

[50Wliu]

Can you reproduce this using an official version of Atom, available at https://atom.io?

[jazzpi]

No, since atom.io doesn't provide an Arch Linux version and building from source breaks with Error: Cannot find module 'node-gyp/bin/node-gyp'. However, I believe the atom-editor-bin package I'm using actually installs Atom from the .deb package on atom.io, and the same issue also occurs on this Travis build.

[jazzpi]

This has been reproduced by @mkiken in lloeki/ex-mode#178 (comment) using an official version of Atom.

[sophaskins]

An example failing spec for the issue is:

      it "works with newline splitting", ->
        buffer = new TextBuffer("abc,def,ghi")
        buffer.scanInRange /,/g, [[0,0], [1,0]], ({replace}) ->
          replace("\n")
        expect(buffer.getText()).toBe "abc\ndef\nghi"

I added this to a checkout of https://github.com/atom/text-buffer at master, and had the following failure:

Failures:
1) TextBuffer ::scanInRange(range, regex, fn) when given a regex with a global flag works with newline splitting
  Message:
    Expected 'abc

    def,ghi' to be 'abc
    def
    ghi'.
  Stack:
    Error: Expected 'abc

    def,ghi' to be 'abc
    def
    ghi'.
        at Object.<anonymous> (/home/sophaskins/development/text-buffer/spec/text-buffer-spec.coffee:1520:34)
        at runCallback (timers.js:672:20)
        at tryOnImmediate (timers.js:645:5)
        at processImmediate [as _immediateCallback] (timers.js:617:5)

[hultberg]

@50Wliu Any news on this issue? 😄