Comments (7)
Yep. Text-buffer requires a version of V8 that includes the full Set
API. If you happen to know what version of node introduced these APIs, I'd be happy to merge a PR adding the appropriate engines
range to our package.json.
from text-buffer.
That makes sense. However there are programs that depend on text-buffer other than Atom. Please consider reverting that commit (which doesn't add anything) so that consumers of text-buffer don't have to support ES6.
from text-buffer.
Using the Set
in event-kit
is important for performance. You should upgrade to node v0.12.
from text-buffer.
In that case, is it possible to bundle a Set
polyfill with atom/event-kit, like this ES6 Set implementation? I am running v0.12 but I cannot expect the thousand or so users of slap-editor/slap to do the same.
from text-buffer.
I would say you should do that in slap-editor
. Set
is a global and can be assigned at any point. It doesn't have to be done within event-kit
.
from text-buffer.
By the way, nice work on slap-editor
. I was unaware that text-buffer
was being used outside of Atom.
from text-buffer.
@dbkaplun If you're going to use the latest text-buffer, why not release a new version with an updated engines
field in package.json
for ^0.12.0
? That way it'll only apply if your users have node ^0.12.0.
from text-buffer.
Related Issues (20)
- Unsaved files reloaded from state don't set modified flag correctly
- After update to 1.14.2 issues with opening large files HOT 7
- text-buffer does not install on Windows HOT 3
- Replacing multiple characters with newlines in a scanInRange only replaces the first occurence HOT 5
- Regular expressions containing \W are multi line.
- TextBuffer v13 fires spurious conflict & reload events HOT 1
- Flaky test - TextBuffer IO when the file changes on disk does not fire duplicate change events when multiple changes happen on disk
- onDidStopChanging and undo Regression in Atom 1.19.4 HOT 4
- existsSync method is necessary; should be reflected in comment HOT 3
- Tracking undo-redo actions HOT 1
- API documentation references DisplayLayer, which is not public
- Missing stub method 'scopeDescriptorForPosition' in NullLanguageMode HOT 1
- 'did-change-text' event is not fired on empty("") to empty("") change after PR#274 HOT 11
- DisplayLayer.updateSpatialIndex error HOT 1
- undo/redo within transact
- Implementing capture groups HOT 1
- TextBuffer makes vim word motion painfully slow in large file HOT 2
- new TextBuffer(); .setFile(...); .reload(); -> .emitDidChangeEvent missing HOT 4
- h HOT 1
- NullHighlightIterator defines getOpenTags/getCloseTags, but everywhere else it's getOpenScopeIds/getCloseScopeIds
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from text-buffer.