Externalise ArtifactSource filtering

[atomist-attic]

Externalise ArtifactSource filtering

[alankstewart]

I agree that filtering is not the responsibility of this library. Will begin making the changes. ArtifactSource already does have a filter method which takes in a DirFilter and FileFilter.

[johnsonr]

Just discussed with Alan. We should add ability to pass two functions to anything that returns an ArtifactSource: One that checks a directory path to see whether it (and its descendants) should be included in the ArtifactSource; and one that checks a file path.

The present filtering mechanism once an ArtifactSource has been constructed should remain unchanged.

Our existing .gitignore support should migrate to the former approach.

[alankstewart]

Callers can send in zero or more filters implementing the ArtifactFilter trait which will apply in order. I have removed JGit from artifact-source and am now using Spring's AntPathMatcher from spring-core. JGit did not filter out the .git directory and so now I created a separate filter called GitDirFilter which can be passed in to the list of filters when creating an ArtifactSource. There is also a GitignoreFileFilter and a AtomistIgnoreFileFilter.

@cdupuis , @kipz I haven't released 0.14.0 of artifact-source yet and I added some sample (commented-out) code to rug-cli which uses the new filters. You can pull artifact-source and use locally. There is no negation of patterns anymore like putting in !node_modules in .atomist/ignore and hoping it will be included if it is specified in .gitignore. These filters work independently so if you want previous behaviour of having to negate !node_modules in .atomist/ignore for example, you will have to write a new filter which handles both ignore files.

[alankstewart]

Sorry, last commits were incorrectly assigned to this issue. Anyhow, this should be complete now