Uncaught TypeError

[atomlinter]

Uncaught TypeError

[Arcanemagus]

Do you have an example file to test trigger this? Or does it happen for you on every file?

[sambev]

I do use postcss syntax for most of my files but it will happen on any kind of css file

[Arcanemagus]

I'm not able to reproduce this, do you have a file that you can share that triggers this?

If not, when you run into this can you put a breakpoint in linter-stylelint right before it returns its messages and see if any of the ranges are invalid?

[1000ch]

@sambev Would you paste CSS example that reproduce this problem?

[sambev]

@1000ch Sure.

.test-list {
    background-color: red;
}

@Arcanemagus I'll try to get into the error a bit more on Monday and post the results. Thanks!

[sambev]

@Arcanemagus looks like my ranges are indeed invalid.

The errors look to be errors with my stylelintrc e.g. I had 'long' as a value for color-hex-case. I am working on fixing them (I can inspect the message objects before the exception).

[sambev]

It looks like after I cleaned up the errors in my stylelintrc file, it's working great.

It seems that with errors in the stylelintrc there is no line, column, rule, or severity with the warning, which kind of makes sense. Not sure what the right fix for this would be. Could we just put dummy values (1, 1, 'misconfigured .stylelintrc', 'critical')?

{line: undefined, column: undefined, rule: undefined, severity: undefined, text: "Expected option value for rule "string-quotes""}

[Arcanemagus]

Yea, that's what is done with other linters, we just create a dummy range encompassing the first line of the file.

[satazor]

@Arcanemagus I was just hit by this issue.. I had errors in my stylelint that led to this. Do you accept a PR which mocks the line, column, etc?

[Arcanemagus]

Of course 😉

[satazor]

@Arcanemagus this is actually more complex than it seems.

There are three kind of errors that might happen:

1 - Invalid syntax of .stylelintrc which cosmic config will detected (this is showing a error notification atm)
2 - Error thrown by stylelint when a fatal error exists, e.g. specifying "extends" pointing to an invalid module (this is being ignored atm)
3 - The actual error described here, where we have a rule with an invalid option that causes line and column to be undefined

How does the other linters deal with 1? Looking at the source code of some of them, I think they simply return a promise that will fail, which causes a error notification to popup. Imho we should do something similar or perhaps show a custom error notification. We are already kind of doing this.

2 needs to be fixed so that all errors thrown by stylelint are handled properly, perhaps display a error notification similar to 1.

3 needs to handle line and column being undefined and display the error at the beginning of the file as suggested.

Thoughts?

[satazor]

This issue can now be closed