Giter Site home page Giter Site logo

Comments (11)

MikeInnes avatar MikeInnes commented on July 29, 2024 3

Or just open an issue on the original repo with a cross-ref, and close it when the tag is merged.

from attobot.

MikeInnes avatar MikeInnes commented on July 29, 2024

Don't watchers get notified when a tag is made?

from attobot.

oxinabox avatar oxinabox commented on July 29, 2024

They don't get notified of any discussion that happens in the METADATA.jl PR though.
and they don't get notified when that PR is Merged, and the release made official.
Knowing the status of that PR is what lets you know if a release has been made.

from attobot.

simonbyrne avatar simonbyrne commented on July 29, 2024

I'm not opposed to the idea, but some people might find it annoying. A big package like Distributions.jl might end up pinging 40-odd people.

from attobot.

tkelman avatar tkelman commented on July 29, 2024

I think "watching" results in a slightly different level of notification than being directly @-mentioned.

from attobot.

oxinabox avatar oxinabox commented on July 29, 2024

I'm not opposed to the idea, but some people might find it annoying. A big package like Distributions.jl might end up pinging 40-odd people.

When you tick the "watching" box, you are signing up to be annoyed.
You get notifications for every new PR and Issue raised.
I think you also get notifications for every comment on every PR or Issue, but I am less sure of that.

For a big repo like Distributions.jl between every release those 40 watchers are already getting at very least half a dozen notifications.
And I assert that they want these notifications, it is why they decided to watch (I certainly do).

I would look at a PR to Metadata as equivalent to a PR or Issue on the repository,

from attobot.

simonbyrne avatar simonbyrne commented on July 29, 2024

Having thought about it a bit more, I broadly agree with your point, though it would be nice if there was a way to do it without mentioning everybody on the issue (one idea is to open a corresponding issue on the repository itself, but that could get messy, as it just leads to 2 places for the same discussion).

I'll hold off for a week or two, as I'm travelling at the moment and won't have time to fix attobot when I inevitably break it. This will also give other people time to chime in.

from attobot.

tkelman avatar tkelman commented on July 29, 2024

a list of 40 names in each pr would get pretty excessive

maybe with some named groups like @attobot/Distributions-watchers, if that's not too much trouble to have attobot auto update that kind of list

from attobot.

dpo avatar dpo commented on July 29, 2024

Bump. I think the OP's proposal is very desirable. At least, it could be an Attobot option. To avoid listing people individually, there may be a way to ping the organization.

from attobot.

oxinabox avatar oxinabox commented on July 29, 2024

Though opening an issue on original repo does risk fragmenting discussion if there are issues with merging.

from attobot.

simonbyrne avatar simonbyrne commented on July 29, 2024

Closed in favour of Registrator.jl

from attobot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.