Fatal error: Call to a member function getLast() on a non-object

[auraphp]

Fatal error: Call to a member function getLast() on a non-object

[harikt]

Pull request initialized .

#3

[pmjones]

Hey man, can you attach a test case for this?

[harikt]

@pmjones also I guess that pull request was too old, so we may want to test the same again.
I will try to write a test case. But I may want your help, lets discuss tonight at irc if I didn't finish it :) .

[harikt]

@pmjones See https://github.com/auraphp/Aura.Signal/blob/master/src/Aura/Signal/Manager.php#L185 , you have already mentioned about the return type ResultCollection The results from each of the Handler objects.
But forgot to return it . So in the above example the results is not having an object of it, hence the error and ie the pull request #3 .

About the test case , I wonder for which one we neeed . About the clone one ?

[harikt]

Another Question is regarding the use of

// clone a new result collection
$this->results = clone $this->result_collection;

in send() , do we need it in constructor then ?

$this->results = clone $this->result_collection;

[pmjones]

I don't think so; the idea is that the manager will have to deal with lots of send()ing, and it's easiest to reuse a clone of the initial empty collection.

[harikt]

ok for clone in send() . What about in constructor ? Or does that answers all ?

[pmjones]

The constructor already has a ResultCollection param. Am I missing what you're getting at?

[harikt]

My query is regarding https://github.com/auraphp/Aura.Signal/blob/master/src/Aura/Signal/Manager.php#L114 . Do we need that there for we already have the clone in send() .

[pmjones]

But we also have getResults(), which needs to return a ResultCollection, even if you haven't called send() yet.

[harikt]

Yup that make sense :) . Sorry for the long conversation :D .