Giter Site home page Giter Site logo

Comments (9)

harikt avatar harikt commented on May 24, 2024

How about send a PR and in case @pmjones finds the time he can merge if that is ok :-) .

from aura.sqlquery.

golgote avatar golgote commented on May 24, 2024

OK I will do that ASAP. I was just checking if you were open to this change.
Thanks.

from aura.sqlquery.

yespire avatar yespire commented on May 24, 2024

Which syntax is better:
1.
single reset() method handle all cases
query->reset() // -- all, paramter is mixed optional
query->reset('order_by') // -- single factor
query->reset(['order_by', 'cols'] // -- multi-factors

a set of specialized reset methods
query->reset() // -- all, no parameter
query->resetCols() // -- no parameter
query->resetOrderBy()

support both 1 + 2

from aura.sqlquery.

harikt avatar harikt commented on May 24, 2024

PR #91 .

from aura.sqlquery.

pmjones avatar pmjones commented on May 24, 2024

There are now 2 PRs in for this issue: #91 and #94. I will pick one of them, or implement the functionality myself. Thanks for your patience!

from aura.sqlquery.

pmjones avatar pmjones commented on May 24, 2024

@golgote @yespire @gauthier @harikt --

I am considering a series of without*() methods that return a clone of the current query. E.g.:

$newQuery = $oldQuery->withoutWhere()->withoutCols()->withoutOrderBy();

That way the existing query continues to exist, and the new one can be independently modified.

Thoughts?

from aura.sqlquery.

pmjones avatar pmjones commented on May 24, 2024

No, on further consideration, we already have some reset*() methods that can be exposed without BC break. I'll expand on those instead. If the user wants a clone, they can clone.

from aura.sqlquery.

harikt avatar harikt commented on May 24, 2024

@pmjones FYI in case if you missed the discussion on #91 (comment) .

from aura.sqlquery.

pmjones avatar pmjones commented on May 24, 2024

Addressed by #95 et al. Let me know if those do not server your purposes.

from aura.sqlquery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.