Giter Site home page Giter Site logo

Comments (7)

adfleshner avatar adfleshner commented on June 2, 2024

So I did a little trying to figure things out and noticed if I put the addItem function in A handler and runnable they would appear. So whether I am the only person this is happening to or it is a bug that you never encountered this is my workaround to fix the disappearing tabs. I can look at the lib and create a pull request or leave it to you ( either or I have fixed the problem on my end and the app works great now and the tabs no longer disappear when I go to a different fragment and then come back )

final Handler handler = new Handler();
        final Runnable r = new Runnable() {
            public void run() {
                bottomNavigation.addItem(item1);
                bottomNavigation.addItem(item2);
                bottomNavigation.addItem(item3);
                bottomNavigation.addItem(item4);
            }
        };
        handler.postDelayed(r, 1);

from ahbottomnavigation.

aurelhubert avatar aurelhubert commented on June 2, 2024

@adfleshner I have tried to test your implementation: I navigate away from the fragmentA with the bottomNavigation to a fragmentB without bottomNavigation and then come back to the fragmentA with the bottomNavigation

I can't reproduce the bug. Can you share more code to explain what you're doing exactly? I think we can maybe find a better fix! :)

from ahbottomnavigation.

adfleshner avatar adfleshner commented on June 2, 2024

https://github.com/adfleshner/TwoPaneProject this is my feeler project that I am using to create my current project. if you go into the code and remove the handler code around the add items the disappearing bug reproduces on my end. I am using all marshmallow emulators and devices.

//Change this 
final Handler handler = new Handler();
       final Runnable r = new Runnable() {
            public void run() {
                bottomNavigation.addItem(item1);
                bottomNavigation.addItem(item2);
                bottomNavigation.addItem(item3);
                bottomNavigation.addItem(item4);
            }
       };
        handler.postDelayed(r, 1);
// to this
//final Handler handler = new Handler();
//       final Runnable r = new Runnable() {
//            public void run() {
                bottomNavigation.addItem(item1);
                bottomNavigation.addItem(item2);
                bottomNavigation.addItem(item3);
                bottomNavigation.addItem(item4);
//            }
//       };
//        handler.postDelayed(r, 1);

This code is in the LeftFragment.java File at line 86

from ahbottomnavigation.

aurelhubert avatar aurelhubert commented on June 2, 2024

@adfleshner Thanks, I will take a look to your project Monday.

from ahbottomnavigation.

adfleshner avatar adfleshner commented on June 2, 2024

@aurelhubert sounds good

from ahbottomnavigation.

aurelhubert avatar aurelhubert commented on June 2, 2024

@adfleshner It should be fixed in the version 1.1.1. Your code and this Stack Overflow post help me to understand what was the problem: http://stackoverflow.com/a/5853333.

from ahbottomnavigation.

adfleshner avatar adfleshner commented on June 2, 2024

Awesome! Thanks all works great now!

from ahbottomnavigation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.