2.0.0-beta.12 - Custom elements instances are now different

[tareqimbasher]

2.0.0-beta.12 - Custom elements instances are now different

[bigopon]

@tareqimbasher can you try with latest beta? it's possible that it's been already fixed, since this looks like a very common scenario.

[tareqimbasher]

Unfortunately not in any timely manner, the latest beta (v15) requires a nontrivial change to decorator usage. That effort however is contingent on having a working app which this issue is blocking. I do see this issue in beta v14 as well.

I'm hoping I can try reproducing this issue in a standalone app to see if v15 would resolve it.

[tareqimbasher]

Is my expectation that a new custom element instance should be returned everytime a correct one? Regardless if it's used within a au-compose rendered block/element or not? And regardless if the custom element is used in a template or resolved directly from the container (container.get(ViewModel)) without the need for newInstanceOf?

[bigopon]

the latest beta (v15) requires a nontrivial change to decorator usage

beta 14 can do, there shouldn't be differences between them with regards to this.

container.get(ViewModel)

this does not result into a new instance, this will follow the standard resolution mode of container.get(). @Sayan751 asked about it too. Having container.get() using different way of resolution is considered inconsistent and thus it was changed from always a new instance to always a singleton.

If you want a new instance, use invoke:

container.invoke(ViewModel)

[tareqimbasher]

Got it, thank you for that last part, that is definitely different than how it was in beta.11.

So just to be sure, is my expectation that a new instance should be created everytime when used in a HTML template correct?

[bigopon]

Aurelia does that. Is your question about your app code?

[tareqimbasher]

My question is what does Aurelia do, which you've answered, thank you. I just didn't want to be expected something that the framework isn't doing by design.

[bigopon]

Thanks @tareqimbasher , closing this.

[tareqimbasher]

@bigopon thank you for answering my questions so far but I believe this issue shouldn't be closed yet as the issue I'm experiencing remains unresolved. I have yet to complete a standalone repro to determine if the problem I described is a change in behavior or some weird glitch specific to my app code.

[bigopon]

Indeed, i was hasty, my apology.