Dialog VM hooks for keyboard (Enter/Escape)

[pape87]

Dialog VM hooks for keyboard (Enter/Escape)

[StrahilKazlachev]

1. Yes, there is no way to pass custom data.
2. I don't understand verify. To verify what? When calling .ok()/.cancel() if the VM implements .canDeactivate, that hook will be called with a DialogCloseResult. So you can see what intention it is being closed with, and prevent the closing if needed by returning false.
3. The keyboard logic is all in the default Renderer implementation. And yes some Renderer options are mixed in the general ones, this has been since day one.

[StrahilKazlachev]

Now that I think about it, both canDeactivate and deactivate hooks are called with DialogCloseResult. So you can manipulate the .output field - definitelyprobably not intended and feels like a hack but it is doable, since we are not freezing the result object(don't think we'll do it).

[pape87]

Yes this solved my issue. I've added some info to the docs about the canDeactivate result parameter.

Thank you

[Alexander-Taran]

@pape87 thanks for your help with docs (-:

[Alexander-Taran]

Oh my!!
and it is referenced in the docs
http://aurelia.io/docs/plugins/dialog#lifecycle-hooks

never knew

[Alexander-Taran]

@pape87 do you think this satisfies you?

[Alexander-Taran]

@pape87 take a look at this comment about interfaces available for dialog vm
aurelia/framework#874 (comment)