Comments (6)
Anytime! 🍻 Happy to spare someone a moment of panic when they see IE not loading.
from vuetensils.
Ok, this is a really good thing to know. Up until recently I've been including a transpiled version. I stopped including that because I figured it adds extra bloat, and the library itself is not really designed to be used directly as is. I always expect the components to be extended upon. I didn't know that Babel would ignore node-modules
folder, so that changes things, I think.
Moving forward comes down to either supporting IE11 in the library via a transpilation step, or showing users how to support it in the docs (as you point out above. thanks!).
I'm leaning towards leaving the transpilation step out, and just having the steps for IE11 support documented. I definitely don't want to completely ignore IE11, but I also prefer not shipping unnecessary code to the 97% of users that are not on IE11.
Open to other thoughts/ideas though, and ultimately I think browser support is part of accessibility which is the number 1 focus of this project.
What do you think?
from vuetensils.
Glad to help! I would also agree that not including polyfills and transpiling is a better approach to reduce bloat. It would also help keep filesize down if you're doing something fancy like bundling a modern and legacy version of your compiled javascript.
I think simply documenting how to make the library compile for IE is good enough. If you're using the CLI for Vue or Nuxt, it's a very small change to the config file.
On that same note of browser compatibility, including a blurb about the components which rely on IntersectionObservers and a link to a good polyfill would be helpful as well (it's just an npm install and an import away). iOS Safari 12.1 and lower doesn't support IntersectionObservers, but Safari 12.2 and up does. iOS users are pretty good at upgrading, but it's good to point out for that one user that refuses to upgrade and reports a bug.
from vuetensils.
Agreed. Actually, only the VIntersect
, VImg
, and the intersect
directive use IntersectionObserver, and they already do have the note about including a polyfill.
Thanks for your support on this. I'll be sure to add the notes about IE11 support to the Introduction section.
from vuetensils.
I also had this issue and I knew Babel do not transpiled node_module by default.
But didn't know Vuetensils was not transpiled in the last releases thanks for bringing it up!
from vuetensils.
Hey, sorry for the delay on this. It's back on my radar now.
from vuetensils.
Related Issues (20)
- Intersect question: how to observe many child elements in v-for loop HOT 3
- [feature] - add complementary role to VAlert HOT 7
- Feature request? tree component? HOT 2
- Error "export 'version' was not found in 'vue' HOT 6
- Feature: Focusout HOT 2
- Import errors in Vue2 with Vite HOT 7
- [Vue warn]: Error in render: "TypeError: errors.get is not a function" HOT 5
- [Feature Request] allow localization of the buttons of the datepicker HOT 5
- [Feature Request] i18n HOT 1
- [Feature Request] VDate: allow inline usage HOT 3
- vue 3 support ? HOT 2
- Website docs don't show any examples anymore HOT 5
- VAlert dismissible doesn't work with scoped css HOT 5
- Vuetensils: TypeError: Object(...) is not a function HOT 5
- Drawer sliding animation HOT 4
- Browser compatibility HOT 7
- [Feature Request] Support Vue 2.7 by upgrading vue-demi to ^0.13 HOT 6
- Failed to resolve entry for package "vuetensils" HOT 3
- Input still has error styling after changing error conditions HOT 9
- Enable class customisation for individual notifications HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vuetensils.