Comments (8)
@mwillbanks @Enngage I'd love your feedback on #133 🎉
from auth0-spa-js.
I agree that will be super useful. Do you want to send a PR with that? If you can't, I'll add our near term backlog to make sure we work on this.
from auth0-spa-js.
Same here, I feel the 30s timeout is way too low :( I would really liked there to be a way to configure custom timeout + way to close popup on any
error.
from auth0-spa-js.
@luisrudge awesome, thank you!
Could you possibly share the reasoning behind the default 30sec timeout? Many users fail to fill in their credentials in such short time.
I like that you can close the popup from within the error using error.popup.close();
, but would it be possible to get an instance of popup when you call auth0.loginWithPopup
(and similar methods) so that we can potentially have more control and close popup whenever we want?
from auth0-spa-js.
@Enngage I'm not sure where you saw a 30s default. I think we always used a 60s timeout.
It's not possible to return the popup in the loginWithPopup
method because when the method finishes, the authentication already happened. I think it's better if we manage the lifecycle of the popup.
from auth0-spa-js.
You can fetch the pop-up today it's a hack but works with most browsers: const win = window.open('', 'auth0:authorize:popup')
from auth0-spa-js.
@luisrudge I thought I saw 30 seconds somewhere, but maybe I confused it with something else :-) Either way the PR looks good and would definitely help accomplish both my issues I have currently with this package. Thank you!
from auth0-spa-js.
You can fetch the pop-up today it's a hack but works with most browsers: const win = window.open('', 'auth0:authorize:popup')
Yes, I can get the reference of the popup in the code, but there's no API that would expose the popup before the code actually runs. For example, how would you get a reference to the popup with this code: await auth0Client.getTokenWithPopup(params);
We could change it to be something like this:
const popup = await auth0Client.getTokenWithPopup(params);
const token = await popup.getToken();
But then we'd be penalizing the most used scenario for a niche use case.
from auth0-spa-js.
Related Issues (20)
- Since v2 getTokenSilently returns expired tokens HOT 5
- Change getTokenSilently error to an instance of a custom error HOT 2
- Verify Id Token fails when client clock is out of sync HOT 10
- Login popup dimensions should be configurable HOT 3
- Distinguish between Missing State and Invalid State HOT 1
- Microsoft Word (or Office) Add-In example with Auth0 SPA JS HOT 1
- Missed Invalid state errors with Generic Error HOT 1
- TransactionManager not using cookieDomain option passed to the library. Instead if uses the current domain. HOT 2
- `amr` property on IdToken is of type `string` HOT 1
- Make authorize URL configurable HOT 6
- "Misconfiguration in the system or a service outage" error in Auth0 HOT 3
- prompt in authorizationParams is not getting override. It is coming none even if it is set to other value like login. HOT 7
- Sophos Cyber Security Endpoint detects ransomware in the package HOT 3
- Total Cookie Protection breaks auth HOT 2
- Better error messaging when out of local storage quota? HOT 4
- Angular SSR window.crypto HOT 1
- User without Organization Membership caused infitine login redirect loop HOT 2
- NullInjectorError HOT 1
- Use '.well-known/openid-configuration' to configure Auth0Provider (Auth0Client) calls HOT 6
- Clarify limits for checkSession method HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auth0-spa-js.