Giter Site home page Giter Site logo

Comments (4)

omsmith avatar omsmith commented on August 24, 2024

Thanks for the report @Pierre-Gilles. The same encoding change effects the secret as well, which is why your edit didn't correct the issue.

Shouldn't be hard to fix up (have it locally), just want to be able to do some performance testing and consider ecosystem impact (it may break workflows of users who have only used the library in Node 5+).

from node-jwa.

Pierre-Gilles avatar Pierre-Gilles commented on August 24, 2024

Thanks for your quick answer.

I completely understand, the goal is not to break other things !

Let me know when you have more news on that.

from node-jwa.

Pierre-Gilles avatar Pierre-Gilles commented on August 24, 2024

Hello,

I'm getting back to you on the issue, do you have the time to test the performance & the ecosystem impact of this modification?

We are still stuck on Node 4 for the moment and really need to change before Node 6 is becoming LTS.

Thank you very much for your time and your help.

from node-jwa.

Pierre-Gilles avatar Pierre-Gilles commented on August 24, 2024

Hi!

I'm really sorry to insist, do you have any changes I can do on my side so we can switch to a more recent version of Node?

Like a way of verifying signature of both Node v4/v6 tokens so we can upgrade without disconnecting all our logged users?

Thank you very much for your time, I totally understand if you don't have the time to push an update on this module, it's just that we need to upgrade to Node v6, and if there is a way to do it on our side without impacting the whole community, that would be great :)

Have a nice day,

from node-jwa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.