Giter Site home page Giter Site logo

Comments (5)

KyleSanderson avatar KyleSanderson commented on June 9, 2024

There's a catch with this one, xxx can have multiple subtitles on a single day, with your dailies maybe having a subtitle or not depending on the person. It's not really that big of a deal because we treat equal episodes as valid for smart episodes and can do the same for dates, but any upgrades may be a bit confused by the situation.

from autobrr.

kenstir avatar kenstir commented on June 9, 2024

So @KyleSanderson , do you think a change like this will cause upgrade problems? I've been watching announces on one tracker for a week, and the US daily shows all seem to be announced with year=2024 season=0 episode=0, but with YYYY.mm.dd in the name. I haven't dug deeply enough yet, but my hypothesis is that an upgrade would work like this:

  • start autobrr v1.39.1
  • filter The Dealy Show 2024 03 05 Guest 1 as Year=2024 Season=0 Episode=0
  • upgrade autobrr with this change
  • filter The Dealy Show 2024 02 28 Old Guest as Year=2024 Season=2024 Episode=228

That is, Season=2024 Episode=228 should still be a valid new episode for smart episodes.

from autobrr.

KyleSanderson avatar KyleSanderson commented on June 9, 2024

So @KyleSanderson , do you think a change like this will cause upgrade problems? I've been watching announces on one tracker for a week, and the US daily shows all seem to be announced with year=2024 season=0 episode=0, but with YYYY.mm.dd in the name. I haven't dug deeply enough yet, but my hypothesis is that an upgrade would work like this:

  • start autobrr v1.39.1
  • filter The Dealy Show 2024 03 05 Guest 1 as Year=2024 Season=0 Episode=0
  • upgrade autobrr with this change
  • filter The Dealy Show 2024 02 28 Old Guest as Year=2024 Season=2024 Episode=228

That is, Season=2024 Episode=228 should still be a valid new episode for smart episodes.

TheShow.2024.03.15.Pandas.First.Ride-CLANS
TheShow.2024.03.15.Carrot.Top-CLANS
TheShow.2024.03.15-CLANS

from autobrr.

kenstir avatar kenstir commented on June 9, 2024

@KyleSanderson I trust your judgement on this, if you think this is not a good or useful enhancement, feel free to close this issue. I will write an external filter.

I am not following the example however. I get that you are inventing titles to make a point, but is it realistic? Are those 3 titles referencing 3 different episodes or the same episode?

from autobrr.

KyleSanderson avatar KyleSanderson commented on June 9, 2024

@KyleSanderson I trust your judgement on this, if you think this is not a good or useful enhancement, feel free to close this issue. I will write an external filter.

I am not following the example however. I get that you are inventing titles to make a point, but is it realistic? Are those 3 titles referencing 3 different episodes or the same episode?

That's the problem, there's atleast two titles there, but we don't know if the third is a unique work, or a duplicate of the first or second. For smart episode the problem is avoided because we accept the same date/episode until a later one is seen.

Anyway, we're going down a hole of a comment on an implementation detail for whoever is going to revisit this one. The issue / enhancement is legit, was just leaving notes.

from autobrr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.