Comments (4)
pluehne
commented on May 29, 2024
I’m not sure about this one, because I think that browsers will look for the default filenames in the root directory.
On the other side, I linked the favicons in the HTML <head> … I’ll investigate whether moving the favicons to docs/assets/images would cause trouble.
from hubble.
filmaj
commented on May 29, 2024
We can certainly use the href attribute for the <link> elements to specify the icons in subdirectories. For the apple icons, according to Apple's documentation on this, it's true that the root directory will be searched for appropriately-named files, but only if the page does not specify <link> elements describing where to look for the icons. In our case, since we have the <link>s, that wouldn't apply to us.
from hubble.
pluehne
commented on May 29, 2024
Thanks for investigating the favicons issue. I also assumed that <link>s would be sufficient to let all kinds of browsers know where to look for favicons/touch icons, but I didn’t find a reliable source and didn’t have the time to search further. I also like the idea of cleaning up the root directory, so let’s move these files as you proposed in #68!
from hubble.
pluehne
commented on May 29, 2024
from hubble.
Related Issues (20)
- Feature Request: Adding Search Analytics
- Monitor successful backup runs HOT 1
- GHE - Hubble implementation, not able to view dashboard HOT 13
- Versions chart broken if load balancer is used? HOT 2
- Cannot parse missing logs after upgrade - KeyError http HOT 2
- List number of deleted repos / archived_repositories
- How to make hubble work for an org on github.com? HOT 3
- Security vulnerabilities found HOT 3
- Hubble install issues HOT 6
- Count number of noop fetches
- Use admin SSH key for data repo
- Enable remote run with docker
- New report for Failed Authentication and menu organization HOT 2
- Does Hubble support gitlab and how to configure it？ HOT 1
- Multiple issues after upgrade to GHES 3.0.8 HOT 8
- Issue while running the code on 3.1.0 HOT 3
- Feature Request: Organization Activity Aggregates HOT 5
- ReportRepoSize not working after 3.x upgrade. HOT 3
- Recommended Git Versions: Update git version database so statistics are reflected correctly
- Feature Request: Templatize `dataUrl` and `footer`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hubble.