Comments (5)
The issue is a little complicated because currently the pitch angle or slope is calculated only on an extrusion body. In this case, the 2 middle slabs are not identified as extrusions (probably because they are not extruded perpendicularly, or simply the ExtrusionAnalyzer is unable to identify the appropriate extrusion) and therefore it does not compute the slope.
In commit 1e10b35, and additional logic for the slope calculation is added by looking as the slope of the top facing largest face to compute the slope/pitch angle. Tested against the attached test case, it shows different pitch angles for each of the slabs that looks correct.
from revit-ifc.
What is expected in this case? There are 2 floors that have Slope angle 5 degree, and the other 2 do not have.
Is it expected that only the 2 Floors with Slope angle 5 degree will have the Pitch Angle in Pset_SlabCommon, whereas the other 2 will have value 0 or no PitchAngle property?
Currently with some works on IFC4 Certification, the result above is obtained.
from revit-ifc.
All four floors are sloped, albeit each by a different method available in Revit.
Any sloped roofs created by the exact same methods correctly report their PitchAngle when exporting to IFC2x3.
I would expect the same to work for floor slabs (i.e. recycle the code used for roofs). At the very least, I would expect the exporter to not export a property with a wrong value (i.e. 0° when the floor slab clearly isn't horizontal).
from revit-ifc.
Just an intermediate test for R2019:
indeed it's fixed for IFC4RV1.2, but not yet for IFC2x3CV2.0
from revit-ifc.
This issue has been fixed as tested in the latest releases: 21.2.0.0, 20.3.1.0, and 19.5.0.0 (coming soon). The example exports are atacched (for IFC4 RV 1.2, and for IFC2x3).
SlabCommon_PitchAngle.zip
from revit-ifc.
Related Issues (20)
- PR: Revit 2023 exporting IFC4 containing a few elements converted into Parts - all elements will be exported as Parts
- ENH: Official Nuget Package
- PR: IfcSpace without FloorArea's in the Qto_SpaceBaseQuantities for Revit 2022
- INQ: Custom property set only for Predefined Type HOT 4
- ENH: Quantities of element layers
- PR: IfcVoidfeature.HOLE exporting to IfcOpening.OPENING
- PR: create parts and ifc mapping problem HOT 2
- ENH: Export Material Description to IfcMaterial.Description in IFC4
- PR: Lots of custom propertys (custom Pset) not visible in IFC HOT 3
- PR: Floors not exporting HOT 15
- PR: Ifc Export includes elements from a different model
- INQ: IFC export trough API HOT 3
- PR: Irregular error occurrence when exporting to IFC HOT 13
- PR: Super long IfcOpeningElements exported
- Qto_BeamBaseQuantities.NetWeight[Type] HOT 9
- PR: No Type-parameters exported to user defined Pset on Door-objects HOT 1
- PR: not able to export built in material parameters into standardised IFC psets HOT 2
- ENH: Inquire about the LOD related matters of IFC
- INQ: Ifc4x3 official release: exporter supporting Quantity Sets HOT 4
- ENH: Add basic build informations HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from revit-ifc.